Fixes Issue #2750 : Inconsistent Behavior with duration.weeks() #2811
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the open issue #2750
Problem
The inconsistency occurs due to the following reasons:
weeks
property behaves likeasWeeks()
for all units except milliseconds or weeks.add
functionality forduration.weeks()
was missing.Fix
weeks
behaves consistently across all units.add
functionality forduration.weeks()
.Verification
For example,
1000000000 milliseconds
equals:This matches the output of the following code:
Result:
Modified Test Case
1 week
to a duration now works as expected.Let me know if further adjustments are needed!