Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update to latest dev OTP version + continuous boarding support (#21)
* Reduce call-n-ride time after trip plan based on call with Thomas * [maven-release-plugin] prepare release otp-1.2.0.7 * [maven-release-plugin] prepare for next development iteration * Revert "VGF-83 if flex service is enabled, must link to segment with CAR permission" This reverts commit 6100d71. * VGF-83 look for car accessible links at beginning of deviated-route search * Some cleanup, future-proofing by making sure transit stops used for call-n-ride are bus accessible (not subway stops) * bugfix VGF-59 * InterleavedBidirectionalHeuristic: do not change underlying request, instead use separate maxWalkDistanceHeuristic value * [maven-release-plugin] prepare release otp-1.2.0.8 * [maven-release-plugin] prepare for next development iteration * Switch to WKT areas for Advance Transit * do not initialize edge map if no streets * bugfix in pattern matcher * bugfix in pattern matcher * fix out-of-DAR issue * VGF-92 fix the implementation of flag stops right at start or end point * VGF-122 add outside-of-area message * Add 'tripDiscoveryMode': look out two weeks in future or past * VGF-64 use drt_advanced_book_max in routing * fix test * version bump * [maven-release-plugin] prepare release otp-1.2.0.9 * [maven-release-plugin] prepare for next development iteration * Add continuous pickup and dropoff messages to api response * change to out-of-area message * bump gtfs * [maven-release-plugin] prepare release otp-1.2.0.10 * [maven-release-plugin] prepare for next development iteration * tripDiscoveryMode - look out a month * VGF-146 actual exclude walk parameter * VGF-80 eligibility services (just 0 and 1 values) * VGF-149 Add trips in past message * VGF-91 let maxWalkDistanceHeuristic be as large as necessary * VGF-91 add minimum length for partial edges * obagtfs version bump * [maven-release-plugin] prepare release otp-1.2.0.11 * [maven-release-plugin] prepare for next development iteration * cleanup * WKT test * Initial commit for Vermont GTFS-flex integration tests * Add BoardAlightType to Ride and make assertions * ADDING MORE TEST * Remove test of not-reservation service (GraphPathFinder not tested in this class) * Remove trip discovery mode * Remove PlanNotesService - feature which adds notes to API results for out-of-area and trip-plan-in-past. Reverts: e3a32da "VGF-149 Add trips in past message" c06ee74 "change to out-of-area message" 2b34e57 "VGF-122 add outside-of-area message" * Remove flag stop transfer generator, unused and untested. * Followup to merge, fix VTrans test * Remove demand-response services * Remove shift by perpendicular vector * Revert change to GenericDijkstra * Remove some non-functional changes relative to OTP-master * Changed calculation of slope costs * Remove nonfunctional change * Fixup RoutingRequest.equals and RoutingRequest.hashCode * Move hop-for-edge map into FlexIndex * serviceDayLookout: add parameter to look more days out in future (or back, for arriveBy=true) * DrtTravelTime fix: 2nd constant could be only one digit * VGF-161 DrtTravelTime fix: 2nd constant could be only one digit * VGF-162 make drt_advance_book_min a double * VGF-163 continuous_pickup and continuous_dropoff change to match spec * bump gtfs-modules * Revert pom.xml changes, except onebusaway-gtfs dependency * Implement the Tobler Hicking Function for calculation of walk distance multiplier. * Formatting change * Add documentation to GTFS-flex parameters * Additional API documentation * Remove license headers * Fix docstring in IndexAPI * Formatting fix * Implement Thomas's GTFS mapping suggestion * Fix compilation error (perhaps due to my version of java): incompatible types: java.util.Comparator<capture#1 of ? extends T> cannot be converted to java.util.Comparator<? super capture#1 of ? extends T> * Add to changelog * Fix issue with maxWalkDistanceHeuristic infinite if not set * Update changelog * bugfix: Geometry vs Polygon in StopPattern * Add termination condition for deviated/call-and-ride pre-search. * Use Math.round for turning angles So that edge pairs get same angles on both sides. Previously they could be truncated differently * Make sure that summing happens on rounded integers * - Fix error in ElevationUtils.java and remove the speed adjustment factor `alkParA` from the calculation. - Cleanup names and comments. - Fix tests. * Revert changes to InterleavedBidirectionalHeuristic * Remove maxWalkDistanceHeuristic * Remove flex parameters from TripShort * Remove deviatedRouteLat/deviatedRouteLon * Add improvements to heuristic for bike rental and car modes * Remove URLs * Add BikeParkVertex to vertices to be searched when estimated remaining weights * Explicitly set euro's for DutchFareService. * Remove the excessive warnings in the Dutch Fare Service. Changed to trace. * Fix bug causing temporary split edges to be of effective walking distance 0 (zero) by setting effectiveWalk distance as coefficient instead of mm. (cherry picked from commit 1818955) (cherry picked from commit d8abd1d) (cherry picked from commit 45df71f) * add missing version opentripplanner#2688 (3.0.1) * fix regex following https://bugs.openjdk.java.net/browse/JDK-8189343 fixes opentripplanner#2691 * update travis to test jdk9 * improve regex * another attempt to fix the regex * fix missing "\" * fix regex (one more try) * add comment and link to jdk ticket * remove modification of travis * Revert "remove modification of travis" This reverts commit 37a6fd6. * undo travis modification * use object differ from stand alone project it was pulled out of r5 to allow reuse * use release version of object-differ * update to object-differ 1.1.0 this ensures that TreeMaps will not cause exceptions in some forks of OTP * Revert car mode changes, improve P&R search and add more comments. * Add parameter documentation and flex parameter prefix. Remove some parameters from API itself. * Add documentation for board-alight types * Standardize API response parameter names for GTFS-Flex * Add units to timeMillis parameter in GraphPathToTripPlanConverter * Rename area to flexArea for disambiguation with other OTP areas * Add to docs * Formatting fix * More documentation * Fix method visibility * Fix Call-And-Ride bug: call-and-ride should be fully within the defined time period. Includes better tests. * Adding more documentation * Refactoring flex-specific fields into a new class/new property of StopPattern * Deduplicate primitive arrays in StopPattern and StopPatternFlexFields * Refactor GTFS-Flex-specific fields out of PatternHop; create new FlexPatternHop class * add documentation for enterStationsWithCar * Remove TemporaryTransitBoardAlight; make FlexTransitBoardAlight inherently temporary. * Refactor to remove bad call-and-ride trip heuristic * Rename parameters * Add more documentation around call-and-ride trip banning * Rename Area to FlexArea * Improve speed of heuristic when car mode is enabled This change will restrict the amount of vertices explored while walking when driving is enabled which should significantly speed up graph searches. * Address GTFS-Flex implications of the new Vertex disposal code in PR opentripplanner#2655 Remove TemporaryEdge list as it is redundant with TemporaryVertices. * Move FlexPatternHop to proper package * fix for hasNext() violation * Prevent TemporaryVertex on a different thread from being reached. In order to do this cleanly, needed to ensure that ALL temporary vertices get added to rctx.temporaryVertices. The temporary subgraph of both endpoints is searched at routing context-creation time. The graph is searched again when the vertices are disposed. * Do not add GTFS-Flex temporary vertices to the graph (formerly these were added, then removed with Graph.remove) * Recalculate the the elevation profile for temporary edges after a split. This apply to biking and walking. * Add documentation * Parameter simplification: allow maxWalkDistance = 0 to be specified and get rid of redundant excludeWalking parameter * Cleanup the creation of temporary vertices and edges when splitting an edge. - Push assigning 'wheelchairAccessible' into the 'TemporarySplitterVertex' constructor. - Create constructor for temporary street edge without a pre-calculated length, calculate length from the geometry in this case. - Update some comments * - Merged super class PartialStreetEdge into child class TemporaryPartialStreetEdge, witch were the only place it was used except for tests. - Simplified the constructors a bit. * Spelling 'hicking' corrected into 'hiking'. * Update Sun Java code conventions link * update to shared serializers in kryo-tools, remove r5 dependency * Refactor heuristic to be sensitive to non-transit mode * Add Javadoc to method This explains that a parameter is ignored and refers to the issue with more info * replace MapDB Tuple2 with OTP T2 Step toward opentripplanner#2431 * Remove two tests, addresses opentripplanner#2431 and opentripplanner#2646 * Materialize generated test graphs to allow opentripplanner#2431 * Remove gtfs-lib dependency, fixes opentripplanner#2431 This also eliminates a MapDB dependency * Remove tests for obsolete classes, fixes opentripplanner#2431 addresses opentripplanner#2646 * update to locationtech geotools opentripplanner#2538 this is based on work by @innovimax in PR opentripplanner#2690 this now compiles and passes all tests under JDK 11 this is simplified by the fact that R5 and gtfs-lib dependencies are eliminated in the branch this is based on * Remove AWS dependencies, fixes opentripplanner#2713 also partially addresses opentripplanner#2646 * Refactor to improve readability * store fare details as array rather than list, addresses opentripplanner#2685 * remove more uses of AWS SDK, opentripplanner#2713 We removed direct AWS dependencies in opentripplanner#2715, but there was still an indirect dependency on AWS SDK via gtfs-lib. So some of the uses of the AWS SDK were not caught until we finally removed the transitive dependency on AWS SDK by removing gtfs-lib. * allow compilation with stricter generics checking * remove dependency on conveyal jackson2-geojson this module defines some geojson serializers. they referred to the old JTS package names which have changed in new versions of JTS. we could patch com.conveyal.jackson2-geojson and re-release it, however JTS now includes its own GeoJSON writing capability, which we are likely to migrate toward. So as a stopgap measure I've copied in our GeoJSON serializer classes and changed the JTS package names they reference. That original code is under Apache 2 license, and Conveyal authorizes its inclusion and/or relicensing here as needed. Note that this is only used in a few places in OTP. * add JAXB API to allow compilation under Java 11 these classes were always available until Java 9, now the module must be added. Perhaps Jackson uses / will use some other annotations now? To be investigated. * add whitespace, remove dead code response to review of PR 2714 * Added the safeRun() method - avoiding the System.exit(-1) call * add factory method for empty coordinate sequences This is used by the new implementation of org.locationtech.jts.io.WKTReader All tests pass with this change * Revert "Added the safeRun() method - avoiding the System.exit(-1) call" This reverts commit 9ea53cf. * add this PR to changelog * The run() method returns a 'success' boolean * Travis build on Openjdk 8 and 11 allowing failures on 11 * fix indentation * remove openjdk 11 from travis build I realized after adding this that it will cause two maven deployments on every release and two uploads to S3 on every build. Let's just occasionally test locally on JDK 11 until it succeeds, then migrate the Travis config to openjdk 11. * PR comments; Removed "Exiting..." from a log line. Added javadocs for the return value of the run() method * PR submitter should add to changelog resolves opentripplanner#2716 * update link * serviceDayLookout: more documentation, refactor to avoid duplicate entries, remove from API parameter * reorder vertex type check in light of flex routing vertices The flex routing changes introduced numerous vertex classes that implement TemporaryVertex. This change makes sure that transit vertices use the transit vertex weights instead of having a 0 weight since the vertices may also be instances of a TemporaryVertex. * Remove CarFreeAtoZ from deployments It has been using R5 for some time now. * Update changelog regarding remove of CarFreeAtoZ * Always store lower-bound estimate of weight in streetSearch * Implement a euclidean heuristic for pre-transit vertices * Only use pre-transit euclidean heuristic in certain circumstances ie when CAR mode is activated or maxWalkDistance is > 5km * Don't use euclidean heuristic for pre-transit vertices in walk+transit queries * Fix opentripplanner#2685: Remove XML annotations from response objects, so that Jackson reverts to default behavior (before 2.7.4) * add line to changelog * Update Changelog.md Add entry to changelog regarding InterleavedBidirectionalHeuristic refactor. * Update Changelog.md Move changelog entry to appropriate place. * Update Changelog.md Add closing paren to changelog entry * Remove repo, add https * Fix JTS coordinate order for Polygons/Polylines * Provide test coverage of bug * Changing min pattern hop length for continuous pickup/dropoff from 400 down to 50 * Disabling flexUseReservationServices to improve performance
- Loading branch information
