fix: emoji icon css fill support #504
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reorder `<path>` elements such that `fill: [color]` fills icons without unintentionally hiding strokes. Except for `emoji-talking-angry.svg`, where the single `<path>` element was split into 2 elements so that fill applied inside the mouth part of the icon.
|
@lucaburgio Lemme know if I need to make these changes somewhere else or in a different way for them to be useful, I would love to contribute! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorder
<path>elements such thatfill: [color]fills icons without unintentionally hiding strokes. Except foremoji-talking-angry.svg, where the single<path>element was split into 2 elements so that fill applied inside the mouth part of the icon.Image shows all modified icons with
fill: #93c5fd;applied. First is original icon, followed by modified icon.