Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Alternate approach to async reads in ZipAESStream #624

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Numpsy
Copy link
Contributor

@Numpsy Numpsy commented May 8, 2021

Alternate approach to #576 which tries taking the simpler approach of using the 'useAsync' idea that some MS libs use for sharing async/sync versions of a function instead of duplicating all the logic, in order to only have a single version of ReadAndTransform

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

@codecov
Copy link

codecov bot commented May 8, 2021

Codecov Report

Merging #624 (f8b19ed) into master (e1e1a91) will increase coverage by 0.05%.
The diff coverage is 96.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #624      +/-   ##
==========================================
+ Coverage   73.82%   73.87%   +0.05%     
==========================================
  Files          69       69              
  Lines        8291     8311      +20     
==========================================
+ Hits         6121     6140      +19     
- Misses       2170     2171       +1     
Impacted Files Coverage Δ
...ICSharpCode.SharpZipLib/Encryption/ZipAESStream.cs 84.61% <92.85%> (+0.32%) ⬆️
src/ICSharpCode.SharpZipLib/Core/StreamUtils.cs 51.78% <100.00%> (+5.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1e1a91...f8b19ed. Read the comment docs.

@Numpsy Numpsy force-pushed the rw/async/async_decryption_2 branch from 063d306 to f8b19ed Compare October 9, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant