[fix] Error Message exposing

idea2app · Aug 1, 2024 · 5acf0bd · 5acf0bd · github-actions · Aug 1, 2024
1 parent bf761fe
commit 5acf0bd
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 6 deletions.
diff --git a/components/NotFoundCard.tsx b/components/NotFoundCard.tsx
@@ -1,11 +1,17 @@
+import { ErrorProps } from 'next/error';
 import { FC } from 'react';
 
 import { i18n } from '../models/Translation';
 
-export const NotFoundCard: FC = () =>
+export const NotFoundCard: FC<ErrorProps> = ({ title }) =>
   i18n.currentLanguage.startsWith('zh') ? (
-    // @ts-ignore
-    <script src="//cdn.dnpw.org/404/v1.min.js" jumptarget="/" jumptime="-1" />
+    <script
+      src="//cdn.dnpw.org/404/v1.min.js"
+      // @ts-ignore
+      jumptarget="/"
+      jumptime="-1"
+      error={title}
+    />
   ) : (
     <iframe
       className="w-100 vh-100 border-0"

diff --git a/pages/_error.tsx b/pages/_error.tsx
@@ -7,11 +7,11 @@ import Error from 'next/error';
 import { NotFoundCard } from '../components/NotFoundCard';
 import { i18n } from '../models/Translation';
 
-const CustomErrorComponent: NextPage<ErrorProps> = ({ statusCode }) => (
+const CustomErrorComponent: NextPage<ErrorProps> = props => (
   <>
-    <h1 className="text-center">{statusCode}</h1>
+    <Error {...props} />
 
-    <NotFoundCard />
+    <NotFoundCard {...props} />
   </>
 );
 const enableSentry =

diff --git a/styles/globals.less b/styles/globals.less
@@ -31,6 +31,10 @@ article {
     max-width: 100%;
   }
 }
+// custom 404 page (Global edition)
+div:has(.next-error-h1) {
+  height: auto !important;
+}
 // custom 404 page (Chinese edition)
 .wrap_404 .wrap_right {
   width: 80vw !important;