Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/delay netcat disconnect in version check #67

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

rbock44
Copy link

@rbock44 rbock44 commented Mar 28, 2020

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions
  • Remember to set idealista:develop as base branch;

Description of the Change

Running the zookeeper installation via ansible and virtualbox vagrant I observed that sometimes the output of zookeeper with netcat is empty. This causes the package to be installed newly.

Instead adding -q 3 will wait 3 seconds before disconnecting from netcat side or disconnecting when server sends a disconnect. Which fixes the problem for me.

Benefits

Provisioning is more stable as connection is longer open and output from zookeeper is provided.

Possible Drawbacks

Worst case is the provisioning takes 3 seconds longer.

Applicable Issues

None known.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants