Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOT RESTRICT FREQ to +/- 32.767Hz #14

Closed
wants to merge 2 commits into from

Conversation

caldweln
Copy link

@caldweln caldweln commented Feb 3, 2020

IEEE Std C37.118.2-2011 Table 6 states for FREQ where 32bit floating point, is "actual frequency value" and thus not restricted to +/- 32.767Hz as with 16bit integer.

IEEE Std C37.118.2-2011 Table 6 states for FREQ where 32bit floating point, is "actual frequency value" and thus not restricted to +/- 32.767Hz as with 16bit integer.
@sstevan
Copy link
Contributor

sstevan commented Feb 3, 2020

Hey @caldweln,

Thanks for the pull request! Just making the reference to #4
Have you managed to test whether the frequency is packed and unpacked correctly now?

I hope this pull request will push me to find some extra time to dig once more if the freq field is packed correctly for sending.

@caldweln
Copy link
Author

caldweln commented Feb 6, 2020

I think the problem is a mis-interpretation of the standard, see my comment in #3

IEEE Std C37.118.2-2011 Table 6 states FREQ is the frequency deviation, unless 32bit floating pt.
In the case of 32bit float it's the actual value and we unpack without adjustment.
In the case of 16bit float it's the deviation and we unpack and restore nominal offset.
@caldweln caldweln closed this Feb 6, 2020
@caldweln caldweln deleted the relax-standards branch February 6, 2020 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants