Fix initial zoom first frame #1864
Open
+72
−129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1863.
Changes
This PR eliminates the post frame function in
AxisChartScaffoldWidgetto calculate thevirtualRect, instead uses theconstraintsofLayoutBuilderand other data available in_stackWidgets.Testing
Since there is no need to wait 1 frame for the zoom to be applied, I removed the related
tester.pumpandexpectfunction calls.I removed the
post frame callback checks if widget is mountedtest, as it is not needed anymore afaik.I am not a 100% sure about changing
updates chart rect after the first frame when controller scale != 1.0toInitializes zoomed chart rect when controller scale != 1.0though, as I don't know the exact purpose of the original test.