Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(boilerplate): App.tsx -> index.tsx #2882

Merged
merged 5 commits into from
Jan 14, 2025

Conversation

frankcalise
Copy link
Contributor

@frankcalise frankcalise commented Jan 10, 2025

Please verify the following:

  • yarn test jest tests pass with new tests, if relevant
  • yarn lint eslint checks pass with new code, if relevant
  • yarn format:check prettier checks pass with new code, if relevant
  • README.md (or relevant documentation) has been updated with your changes
  • If this affects functionality there aren't tests for, I manually tested it, including by generating a new app locally if needed (see docs).

Describe your PR

  • A discussion in Slack broke out about why does App.tsx pass the hideSplashScreen. The ultimate reason was because in v8 we supported both expo-splash-screen and react-native-bootsplash
  • This PR simplifies some of the boilerplate's entry point
  • Renames App.tsx -> index.tsx to be more aligned with the React Navigation template of Expo's default app (via yarn create expo my-app --template react-navigation/template)

@frankcalise frankcalise marked this pull request as ready for review January 12, 2025 16:57
@frankcalise frankcalise merged commit 42ac86a into master Jan 14, 2025
1 check passed
@frankcalise frankcalise deleted the frankcalise/fix-App-to-index branch January 14, 2025 12:21
infinitered-circleci pushed a commit that referenced this pull request Jan 14, 2025
## [10.1.4](v10.1.3...v10.1.4) (2025-01-14)

### Bug Fixes

* **boilerplate:** App.tsx -> index.tsx ([#2882](#2882) by [@frankcalise](https://github.com/frankcalise)) ([42ac86a](42ac86a))
@infinitered-circleci
Copy link

🎉 This PR is included in version 10.1.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants