server: accept TLS certificate and key #2398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug in the cliopts hook for FromString. It was incorrectly returning the reflect.Value instead of the underlying value.
dnephin
requested review from
ssoroka,
BruceMacD,
jmorganca,
pdevine and
kimskimchi
as code owners
dnephin
commented
Jun 24, 2022
| BasicConstraintsValid: true, | ||
| } | ||
|
|
||
| caPrivKey, err := rsa.GenerateKey(rand.Reader, 4096) | ||
| caBytes, err := x509.CreateCertificate(rand.Reader, ca, ca, &caPrivKey.PublicKey, caPrivKey) |
There was a problem hiding this comment.
Previously we were only creating the x509.Certificate manually, which does not give us any way to serialize it (as far as I can tell).
By calling CreateCertificate it creates the asn.1 DER bytes we need to serialize the certificate. When doing this I ran into an error which I believe is because we were not setting IsCA above.
I left a TODO below about this, but I could not find any other way to allow us to serialize this CA.
3 tasks
BruceMacD
approved these changes
Jun 27, 2022
| // certificate, or that will be used to generate a certificate if one was | ||
| // not provided. | ||
| CA types.StringOrFile | ||
| CAPrivateKey string |
There was a problem hiding this comment.
What will the CAPrivateKey here be used for? It's only in a test at the moment and frequently people won't have access to this.
There was a problem hiding this comment.
Good question, it gets used in #2401 which is the follow up to this
Co-authored-by: Bruce MacDonald <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow a user to specify the certificate and key to use for TLS.
Also fixes a couple bugs:
clioptshook for using aSet(string) errorfunction to parse a config field from a stringRelated Issues
This is part 1 of #2176