Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Refactor prepare_name_pairs_pd to pass arguments to create_positive_negative_samples #32

Merged
merged 8 commits into from
Dec 1, 2024

Conversation

chrispyl
Copy link
Collaborator

@chrispyl chrispyl commented Nov 30, 2024

prepare_name_pairs_pd is not passing the column names for uid, correct, and positive set columns to create_positive_negative_samples.

In this pr:

  • correct_col, uid_col, gt_uid_col, preprocessed_col, gt_preprocessed_col become parameters for prepare_name_pairs_pd
  • the corresponding hardcoded values of prepare_name_pairs_pd become default values for these columns and are replaced by the variables
  • the above columns are passed from create_training_name_pairs to prepare_name_pairs for both pandas and spark versions
  • uid_col, correct_col, positive_set_col are passed from prepare_name_pairs_pd to create_positive_negative_samples

@chrispyl chrispyl changed the title Refactor prepare name pairs FIX: Refactor prepare name pairs Nov 30, 2024
@chrispyl chrispyl changed the title FIX: Refactor prepare name pairs FIX: Refactor prepare_name_pairs_pd to pass arguments to create_positive_negative_samples Nov 30, 2024
@mbaak mbaak merged commit 3f20da8 into ing-bank:main Dec 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants