[FIX] l10n_ar_tax: print payment reports without secondary currency #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, we were receiving the following traceback when trying to print the report of a payment that has no secondary currency set:
Traceback (most recent call last):
[..]
File "/data/build/adhoc-cicd-odoo-odoo/odoo/addons/base/models/ir_qweb.py", line 601, in _render
result = ''.join(rendering)
File "<1147>", line 84, in template_1147
File "<1147>", line 66, in template_1147_content
File "<1147>", line 54, in template_1147_t_call_0
File "<5377>", line 1690, in template_5377
odoo.addons.base.models.ir_qweb.QWebException: Error while render the template
ZeroDivisionError: float division by zero
Template: l10n_ar_tax.report_payment_receipt_document
Path: /t/t/table[1]/tbody/t[1]/tr/td[3]/span
Node: