Expose prompt option in login method #3759
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mostly a feature request, but I figured I'd open a PR with the changes to propose a solution.
The feature request is basically to expose the
prompt
option in the login. I always thought that working with various Solid PODs was annoying because they asked for confirmation in every page reload, but recently I realized it's actually the expected behaviour because this library sends the "consent" prompt parameter during the authentication request. This is done internally, so it would be nice to expose this to clients and let them decide how to behave.Currently, this can be bypassed using the
prompt
parameter anyways, and telling Typescript to ignore the problem. But there is another issue. Eventually, the prompt parameter is resolved using a null coalescing operator that defaults to "consent". This is a problem because in some implementations (for example, in Laravel), there is a distinction between using "none" or omitting the parameter altogether. There should be a way to explicitly avoid sending the parameter, even if the default behaviour is to use "consent".