Fix browser demo error management #3842
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #3841. The browser demo no longer passes an incorrect argument (from a TS perspective) to the `handleIncomingRedirect` function. This also fixes how the React app root is created with respect to the latest upgrade.
chelseapinka
approved these changes
Jan 23, 2025
NSeydoux
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Error
NSeydoux
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Error
NSeydoux
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Error
NSeydoux
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Error
NSeydoux
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Error
NSeydoux
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
NSeydoux
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
NSeydoux
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
NSeydoux
commented
Jan 24, 2025
| @@ -73,53 +73,45 @@ export default function App() { | |||
| }); | |||
| }; | |||
|
|
|||
| const handleLogout = (e) => { | |||
| e.preventDefault(); | |||
There was a problem hiding this comment.
Using type="button" on the button tag, the default "submit" behavior (causing a page refresh) is diabled.
| // The default behaviour of the button is to resubmit. | ||
| // This prevents the page from reloading. | ||
| e.preventDefault(); | ||
| events().on(EVENTS.ERROR, errorHandle); |
There was a problem hiding this comment.
This is how error events should be handled on the session.
| import App from "./App"; | ||
|
|
||
| ReactDOM.render(<App />, document.getElementById("container")); |
There was a problem hiding this comment.
This approach was deprecated from React in a previous version.
NSeydoux
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
NSeydoux
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
NSeydoux
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
NSeydoux
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
chelseapinka
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3841.
The browser demo no longer passes an incorrect argument (from a TS perspective) to the
handleIncomingRedirectfunction. This also fixes how the React app root is created with respect to the latest upgrade.