E2E test application-defined request metadata #2283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
NSeydoux
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Error
NSeydoux
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Error
NSeydoux
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Error
jeswr
reviewed
Dec 13, 2023
e2e/node/request-metadata.test.ts
Outdated
| }; | ||
| }; | ||
|
|
||
| describe.each(headers)( |
There was a problem hiding this comment.
Jest expects an array of arrays here where the nth element of each element array corresponds to the nth argument of the callback function
Suggested change
| describe.each(headers)( | |
| describe.each(headers.map(header => [header]))( |
There was a problem hiding this comment.
The mapping is implicit for 1-D arrays according to the docs: https://jestjs.io/docs/api#1-describeeachtablename-fn-timeout
NSeydoux
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Error
NSeydoux
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Error
NSeydoux
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Error
e2e/node/request-metadata.test.ts
Outdated
| readHeaders, | ||
| ); | ||
|
|
||
| // The response will be a 401 |
There was a problem hiding this comment.
if this is a resolves.not.toThrow is that actually a 401? this comment seems right but the validator seems wrong.
There was a problem hiding this comment.
solid-client acts as a high-level client, and as such it will throw on 401 or 403.
NSeydoux
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
NSeydoux
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Error
NSeydoux
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
NSeydoux
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
NSeydoux
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
jeswr
approved these changes
Dec 14, 2023
NSeydoux
deleted the
feat/SDK-3263/application-defined-request-metadata
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds end-to-end tests for application-defined request metadata. The tests scenarios are a combination of authenticated and unauthenticated requests, with success and error responses.