Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to png logo #254

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Revert to png logo #254

merged 2 commits into from
Jan 8, 2025

Conversation

llrs-roche
Copy link
Contributor

@llrs-roche llrs-roche commented Jan 8, 2025

After conversations with @ddsjoberg I revert back to the png to not break other projects that link to the png file and because the svg file is slightly bigger than the png (maybe due to the background).


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • If a new ard_*() function was added, it passes the ARD structural checks from cards::check_ard_structure().
  • If a new ard_*() function was added, set_cli_abort_call() has been set.
  • If a new ard_*() function was added and it depends on another package (such as, broom), is_pkg_installed("broom") has been set in the function call and the following added to the roxygen comments: @examplesIf do.call(asNamespace("cardx")$is_pkg_installed, list(pkg = "broom""))
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cardx (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

@llrs-roche llrs-roche requested a review from ddsjoberg January 8, 2025 09:23
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Unit Tests Summary

  1 files  161 suites   1m 12s ⏱️
159 tests 125 ✅ 34 💤 0 ❌
592 runs  546 ✅ 46 💤 0 ❌

Results for commit 1a2d9aa.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
ard_attributes.survey.design 💚 $1.60$ $-1.58$ $0$ $+1$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
ard_aod_wald_test 💔 $0.25$ $+1.35$ ard_aod_wald_test_works
ard_attributes.survey.design 💚 $1.60$ $-1.58$ ard_attributes.survey.design_works
ard_continuous.survey.design 💔 $15.67$ $+5.62$ unstratified_ard_continuous.survey.design_works
construction_helpers 💚 $2.32$ $-1.67$ construct_model_works
proportion_ci 💚 $1.86$ $-1.71$ check_the_proportion_ci__functions_work

Results for commit d69f69a

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@ddsjoberg ddsjoberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @llrs-roche for the swap! 🙇🏼

@ddsjoberg ddsjoberg merged commit e3d328d into main Jan 8, 2025
33 checks passed
@ddsjoberg ddsjoberg deleted the revert_logo@main branch January 8, 2025 16:29
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants