added comment, test and NEWS

insightsengineering · Nov 22, 2024 · 7204055 · 7204055
1 parent ed93699
commit 7204055
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -15,6 +15,8 @@
 
 ### Bug Fixes
  * Fixed bug that was keeping indentation space characters in top left information when making a `flextable` from a `TableTree` object.
+ * Fixed bug in `analyze` that was causing an error when passing a single `NA` value to the
+`var_labels` parameter.
 
 ## rtables 0.6.10
 

diff --git a/R/colby_constructors.R b/R/colby_constructors.R
@@ -1113,6 +1113,9 @@ analyze <- function(lyt,
                     section_div = NA_character_) {
   show_labels <- match.arg(show_labels)
   subafun <- substitute(afun)
+  # R treats a single NA value as a logical atomic. The below
+  # maps all the NAs in `var_labels` to NA_character_ required by `Split`
+  # and avoids the error when `var_labels` is just c(NA).
   var_labels <- vapply(var_labels, function(label) ifelse(is.na(label), NA_character_, label), character(1))
   if (
     is.name(subafun) &&

diff --git a/tests/testthat/test-colby_constructors.R b/tests/testthat/test-colby_constructors.R
@@ -0,0 +1,7 @@
+test_that("analyze's var_labels accepts a vector of length 1 consisting of a single NA", {
+  testthat::expect_no_error(
+    basic_table() %>%
+      split_cols_by("ARM") %>%
+      analyze("AGE", var_labels = c(AGE = NA))
+  )
+})