Update DESCRIPTION min xml12

[shajoezhu]

No description provided.

[github-actions]

Unit Tests Summary

    1 files     28 suites   1m 36s ⏱️
  218 tests   218 ✅ 0 💤 0 ❌
1 579 runs  1 579 ✅ 0 💤 0 ❌

Results for commit dc7bdb3.

♻️ This comment has been updated with latest results.

[Melkiades]

lgtm! Thanks Joe

[shajoezhu]

[ FAIL 4 | WARN 0 | SKIP 0 | PASS 1568 ]

══ Failed tests ════════════════════════════════════════════════════════════════
── Error (test-colby_constructors.R:2:3): analyze's var_labels accepts a vector of length 1 consisting of a single NA ──
Error: 'expect_no_error' is not an exported object from 'namespace:testthat'
── Error (test-result_data_frame.R:356:3): make_ard works with multiple row levels ──
Error in expect_contains(colnames(ard_out), c("group2", "group2_level")): could not find function "expect_contains"
── Error (test-result_data_frame.R:389:3): make_ard works with multiple column levels ──
Error in expect_contains(colnames(ard_out), c("group1", "group1_level")): could not find function "expect_contains"
── Error (test-result_data_frame.R:424:3): make_ard works with summarize_row_groups ──
Error in expect_contains(unique(ard_out$stat_name), c("mean", "n", "p")): could not find function "expect_contains"

[github-actions]

Unit Test Performance Difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
Accessing and subsetting tables	💔	$3.76$	$+1.93$	$0$	$0$	$0$	$0$
Analysis functions (afun)	💔	$3.70$	$+1.35$	$0$	$0$	$0$	$0$
Exporting to txt, pdf, rtf, and docx	💔	$11.56$	$+4.57$	$0$	$0$	$0$	$0$
Pagination	💔	$17.37$	$+7.94$	$0$	$0$	$0$	$0$
Printing tables	💔	$5.72$	$+2.79$	$0$	$0$	$0$	$0$
Result Data Frames	💔	$7.14$	$+3.32$	$0$	$0$	$0$	$0$
Tabulation framework	💔	$19.62$	$+8.83$	$0$	$0$	$0$	$0$
compare_rtables	💔	$2.20$	$+1.01$	$0$	$0$	$0$	$0$
regression tests	💔	$4.33$	$+1.79$	$0$	$0$	$0$	$0$
sorting and pruning	💔	$5.56$	$+2.34$	$0$	$0$	$0$	$0$

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
Analysis functions (afun)	💔	$3.14$	$+1.15$	.spl_context_and_afun_extra_parameters_contain_information_about_combo_counts
Exporting to txt, pdf, rtf, and docx	💔	$4.15$	$+1.64$	export_as_pdf_works
Exporting to txt, pdf, rtf, and docx	💔	$2.81$	$+1.12$	exporting_pdf_does_the_inset
Pagination	💔	$2.97$	$+1.33$	setting_colgap_during_pagination_works
Pagination	💔	$8.32$	$+3.92$	vertical_and_horizontal_pagination_work
Tabulation framework	💔	$9.55$	$+4.36$	qtable_works
compare_rtables	💔	$2.20$	$+1.01$	compare_rtables

Results for commit 4400537

♻️ This comment has been updated with latest results.

[shajoezhu]

hi @pawelru ,

! Failed to build source package xml2., stdout + stderr:

OE> * installing *source* package ‘xml2’ ...
OE> ** package ‘xml2’ successfully unpacked and MD5 sums checked
OE> staged installation is only possible with locking
OE> ** using non-staged installation
OE> Found pkg-config cflags and libs!
OE> Using PKG_CFLAGS=-I/usr/include/libxml2
OE> Using PKG_LIBS=-lxml2
OE> ** libs
OE> using C compiler: ‘gcc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0’
OE> using C++ compiler: ‘g++ (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0’
OE> g++ -std=gnu++17 -I"/usr/local/lib/R/include" -DNDEBUG -I../inst/include -I/usr/include/libxml2 -DUCHAR_TYPE=wchar_t  -I/usr/local/include   -fvisibility=hidden -fpic  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -Wall -pedantic  -c connection.cpp -o connection.o
OE> gcc -I"/usr/local/lib/R/include" -DNDEBUG -I../inst/include -I/usr/include/libxml2 -DUCHAR_TYPE=wchar_t  -I/usr/local/include    -fpic  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -Wall -pedantic -c init.c -o init.o
OE> g++ -std=gnu++17 -I"/usr/local/lib/R/include" -DNDEBUG -I../inst/include -I/usr/include/libxml2 -DUCHAR_TYPE=wchar_t  -I/usr/local/include   -fvisibility=hidden -fpic  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -Wall -pedantic  -c xml2_doc.cpp -o xml2_doc.o
OE> g++ -std=gnu++17 -I"/usr/local/lib/R/include" -DNDEBUG -I../inst/include -I/usr/include/libxml2 -DUCHAR_TYPE=wchar_t  -I/usr/local/include   -fvisibility=hidden -fpic  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -Wall -pedantic  -c xml2_init.cpp -o xml2_init.o
OE> xml2_init.cpp: In function ‘void handleGenericError(void*, const char*, ...)’:
OE> xml2_init.cpp:37:12: error: format not a string literal and no format arguments [-Werror=format-security]
OE>    37 |   Rf_error(buffer);
OE>       |            ^~~~~~
OE> cc1plus: some warnings being treated as errors
OE> make: *** [/usr/local/lib/R/etc/Makeconf:204: xml2_init.o] Error 1
OE> ERROR: compilation failed for package ‘xml2’
OE> * removing ‘/tmp/RtmpZWGkJk/pkg-libc26e4790b0/xml2’
Error in "stop_task_build(state, worker)" : 
  ! Failed to build source package xml2.
In addition: Warning message:
In FUN(X[[i]], ...) : Ignoring R version requirement: NA NA

I feel with the min dependency test, the success also depends on the machine that we are testing on. but not really related to the package itself. I wonder what's our strategy with issues like this. Thanks

[pawelru]

I feel with the min dependency test, the success also depends on the machine that we are testing on. but not really related to the package itself. I wonder what's our strategy with issues like this. Thanks

This had been already detected and unfortunately I don't have anything else in my head other than just vbump it to the working version