Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upversion dep #1308

Merged
merged 2 commits into from
Jan 15, 2025
Merged

upversion dep #1308

merged 2 commits into from
Jan 15, 2025

Conversation

shajoezhu
Copy link
Contributor

Pull Request

Fixes #nnn

@llrs-roche
Copy link
Contributor

I'm seeing some problems on the CI about conflict versions on #1309, and here too. Is this PR related to those issues? Is this PR to test some changes on the CI?

@shajoezhu
Copy link
Contributor Author

hi @llrs-roche , there are several changes upstream in formatters, rtables, and tern, I think there are potential breaking changes in at least two places, as preparing releases, I updated the description file, and would love to use our cicd pipeline to help me identify the changes needed

DESCRIPTION Outdated Show resolved Hide resolved
Signed-off-by: Joe Zhu <[email protected]>
Copy link
Contributor

github-actions bot commented Jan 10, 2025

Unit Tests Summary

    1 files     70 suites   1h 9m 34s ⏱️
  727 tests   614 ✅ 113 💤 0 ❌
1 987 runs  1 759 ✅ 228 💤 0 ❌

Results for commit 7991abf.

♻️ This comment has been updated with latest results.

Copy link
Contributor

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_a_mmrm 💔 $742.31$ $+1.13$ $0$ $0$ $0$ $0$
shinytest2-tm_g_barchart_simple 💔 $223.04$ $+3.57$ $0$ $0$ $0$ $0$
shinytest2-tm_g_forest_rsp 💔 $173.89$ $+1.74$ $0$ $0$ $0$ $0$
shinytest2-tm_g_km 💔 $267.11$ $+1.40$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events_patyear 💔 $51.18$ $+1.04$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events_summary 💔 $67.98$ $+1.00$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_laboratory 💔 $123.77$ $+1.55$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_grade 💔 $77.21$ $+2.21$ $0$ $0$ $0$ $0$
shinytest2-tm_t_tte 💔 $65.49$ $+1.00$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
shinytest2-tm_a_mmrm 💔 $49.74$ $+1.19$ e2e_tm_a_mmrm_Validate_output_on_different_selection_on_method_t_mmrm_lsmeans.

Results for commit 5ab5441

♻️ This comment has been updated with latest results.

@shajoezhu shajoezhu added the sme label Jan 12, 2025
@shajoezhu shajoezhu enabled auto-merge (squash) January 15, 2025 01:18
Copy link
Contributor

@edelarua edelarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@shajoezhu shajoezhu merged commit 26a506c into main Jan 15, 2025
29 checks passed
@shajoezhu shajoezhu deleted the upversion_deps branch January 15, 2025 01:22
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants