-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
503 shinytest2 for session info link in bottom of the page #1145
Conversation
Hey @vedhav and @averissimo a small PR for a |
Unit Tests Summary 1 files 25 suites 1m 27s ⏱️ Results for commit 89f40ae. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Additional test case details
Results for commit 4ce2388 ♻️ This comment has been updated with latest results. |
Code Coverage Summary
Diff against main
Results for commit: 89f40ae Minimum allowed coverage is ♻️ This comment has been updated with latest results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great spec!
I think these two need to be implemented before merging
- Avoid
nth-child(2)
(similar to 503 shinytest2 forShow R code
modal #1146). - Use
expect_match
instead ofgreplf
Additionally, a minor comment on checking the labels of the buttons at once.
…t attached to the name of the session info panel
Co-authored-by: André Veríssimo <[email protected]> Signed-off-by: Marcin <[email protected]>
389c96f
to
7047261
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Part of https://github.com/insightsengineering/coredev-tasks/issues/503