Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

503 shinytest2 for session info link in bottom of the page #1145

Merged
merged 10 commits into from
Mar 19, 2024

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Mar 12, 2024

@m7pr m7pr added the core label Mar 12, 2024
@m7pr m7pr changed the base branch from main to 503-introduce-shinytest2@main March 12, 2024 10:14
@m7pr m7pr marked this pull request as ready for review March 12, 2024 10:14
@m7pr m7pr requested review from averissimo and vedhav March 12, 2024 10:14
@m7pr
Copy link
Contributor Author

m7pr commented Mar 12, 2024

Hey @vedhav and @averissimo a small PR for a sessionInfo modal in teal app.
I would need your help figuring out how to replace button:nth-child(2) part in selectors for Dismiss button with data selector.

Copy link
Contributor

github-actions bot commented Mar 12, 2024

Unit Tests Summary

  1 files   25 suites   1m 27s ⏱️
225 tests 225 ✅ 0 💤 0 ❌
474 runs  474 ✅ 0 💤 0 ❌

Results for commit 89f40ae.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Mar 12, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-init 💔 $6.68$ $+3.81$ $+12$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
shinytest2-init 👶 $+3.84$ e2e_teal_app_initializes_with_sessionInfo_modal

Results for commit 4ce2388

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Mar 12, 2024

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  -------------------------------------------------------------------------------------------------------------------------------
R/dummy_functions.R                  30       0  100.00%
R/get_rcode_utils.R                  31       1  96.77%   50
R/include_css_js.R                   22       0  100.00%
R/init.R                             86      25  70.93%   108-115, 161-162, 164, 179-185, 192-197, 228
R/landing_popup_module.R             25      25  0.00%    61-87
R/module_filter_manager.R           107      29  72.90%   50-58, 67-72, 195, 200-213
R/module_nested_tabs.R              154       3  98.05%   47, 128, 228
R/module_snapshot_manager.R         209     157  24.88%   87-99, 127-136, 140-152, 154-161, 168-182, 186-188, 190-195, 198-208, 211-227, 236-251, 265-288, 291-302, 305-311, 325, 343-366
R/module_tabs_with_filters.R         76       0  100.00%
R/module_teal_with_splash.R         114       2  98.25%   110, 131
R/module_teal.R                     106       1  99.06%   57
R/modules.R                         153      24  84.31%   127-130, 147-151, 206-210, 292-293, 345, 357-365
R/reporter_previewer_module.R        18       0  100.00%
R/show_rcode_modal.R                 19      19  0.00%    17-36
R/tdata.R                            53       1  98.11%   154
R/teal_data_module-eval_code.R       27       0  100.00%
R/teal_data_module-within.R           7       0  100.00%
R/teal_data_module.R                  6       0  100.00%
R/teal_reporter.R                    62       5  91.94%   69, 118-119, 122, 139
R/teal_slices-store.R                29       0  100.00%
R/teal_slices.R                      59      12  79.66%   137-150
R/TealAppDriver.R                   195      61  68.72%   66-77, 124-127, 135, 146-147, 155, 167-168, 190-196, 278-325, 369, 402
R/utils.R                           173       1  99.42%   255
R/validate_inputs.R                  32       0  100.00%
R/validations.R                      58      37  36.21%   110-377
R/zzz.R                              11       7  36.36%   3-14
TOTAL                              1862     410  77.98%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 89f40ae

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@averissimo averissimo self-assigned this Mar 14, 2024
Copy link
Contributor

@averissimo averissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great spec!

I think these two need to be implemented before merging

  1. Avoid nth-child(2) (similar to 503 shinytest2 for Show R code modal #1146).
  2. Use expect_match instead of greplf

Additionally, a minor comment on checking the labels of the buttons at once.

tests/testthat/test-shinytest2-init.R Outdated Show resolved Hide resolved
tests/testthat/test-shinytest2-init.R Outdated Show resolved Hide resolved
tests/testthat/test-shinytest2-init.R Outdated Show resolved Hide resolved
@m7pr m7pr requested a review from averissimo March 14, 2024 12:56
Base automatically changed from 503-introduce-shinytest2@main to main March 18, 2024 12:05
@vedhav vedhav changed the base branch from main to 503-introduce-shinytest2@main March 18, 2024 12:58
@vedhav vedhav force-pushed the session-info@503-introduce-shinytest2@main branch from 389c96f to 7047261 Compare March 18, 2024 13:01
@vedhav vedhav changed the base branch from 503-introduce-shinytest2@main to main March 18, 2024 13:01
Copy link
Contributor

@averissimo averissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@m7pr m7pr enabled auto-merge (squash) March 18, 2024 15:44
@m7pr m7pr merged commit 1890e05 into main Mar 19, 2024
20 checks passed
@m7pr m7pr deleted the session-info@503-introduce-shinytest2@main branch March 19, 2024 09:50
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants