i18n: Mark Strings for Translations #1894
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samk13
force-pushed
the
fix-translations
branch
4 times, most recently
from
165b1b4 to
88ae05f
Compare
Samk13
force-pushed
the
fix-translations
branch
from
88ae05f to
5adaf45
Compare
Samk13
force-pushed
the
fix-translations
branch
4 times, most recently
from
2fef4f0 to
8928a1a
Compare
* Checked the spelling or embargoes here: https://dictionary.cambridge.org/dictionary/english/embargoes
Samk13
force-pushed
the
fix-translations
branch
2 times, most recently
from
9cd7025 to
0061ba3
Compare
* As of the Invenio docs, f strings are not supported, see: https://inveniordm.docs.cern.ch/develop/howtos/i18n/#python issue: python-babel/babel#594 * Remove f string usage in: - invenio_rdm_records/requests/access/requests.py - invenio_rdm_records/services/pids/errors.py
* Update string formatting for compatibility with i18n the following strings were updated: resources/serializers/utils.py services/pids/errors.py
Samk13
force-pushed
the
fix-translations
branch
from
0061ba3 to
a416b7f
Compare
| @@ -55,7 +57,7 @@ def metadata(self): | |||
| { | |||
| "person_or_org": { | |||
| "type": "personal", | |||
| "family_name": "Unknown", | |||
| "family_name": _("Unknown"), | |||
There was a problem hiding this comment.
is that Unknown really a to translatable string? it seems like an item of a controlled vocabulary.
There was a problem hiding this comment.
Controlled vocabularies should not be translated since they serve as language-agnostic identifiers. However, in this case, the code seems to be setting a fallback value specifically for display purposes, meaning it is intended for end users. or?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❤️ Thank you for your contribution!
Description
Mark missing strings for translations
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: