resources: add param to filter shared with my uploads #1956
Conversation
* returns record needs on entity resolution * reindex associated request on parent access changes
|
|
||
| if params.get("shared_with_me") is True: | ||
| # Shared with me | ||
| return search.filter(~my_uploads) |
There was a problem hiding this comment.
Is a record not owned by me necessarily shared with me?
Can there be other use cases, maybe related to communities, where a record was not explicitly shared with me, but where I am also not the owner?
There was a problem hiding this comment.
Basically does this mean that on a community inclusion, will it appear as "shared with me", when it's not the case right?
There was a problem hiding this comment.
Exactly, you will see all your community related requests there. In principle, the shared with me is at the moment an umbrella to see all the records that yourself didn't create.
| @@ -97,7 +97,7 @@ | |||
| from .schemas.tombstone import TombstoneSchema | |||
| from .search_params import ( | |||
| MetricsParam, | |||
| MyDraftsParam, | |||
| MyOrSharedWIthMeDraftsParam, | |||
There was a problem hiding this comment.
Maybe a better name could be (as in the other PR):
| MyOrSharedWIthMeDraftsParam, | |
| SharedOrMineDraftsParam, |
|
|
||
| if params.get("shared_with_me") is True: | ||
| # Shared with me | ||
| return search.filter(~my_uploads) |
There was a problem hiding this comment.
Basically does this mean that on a community inclusion, will it appear as "shared with me", when it's not the case right?
|
Regarding #1956 (comment) : Yes if you have access you will see it in the shared view. So, a community inclusion to a community you can curate gives you access to the record. |
zzacharo
force-pushed
the
shared-uploads
branch
from
1ab411b to
d138c76
Compare
… user communities
| # Update parent request on access changes | ||
| # | ||
|
|
||
| def _update_parent_request(self, parent, uow): |
There was a problem hiding this comment.
just for my information to understand how this works: why is it needed?
There was a problem hiding this comment.
It is needed so when a user changes the access in a record via the share button, the record/request is shown to the user that the record was shared with under their dashboard.
that is now changed to not include community related uploads/requests |
zzacharo
force-pushed
the
shared-uploads
branch
2 times, most recently
from
8759d15 to
cd9e6ab
Compare
closes #1948