IfRecordDeleted: a more precise query for deletion status #1968
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The query_filter of
IfRecordDeleted(then_, else_)
is implemented as:(match_all & then_) | (if not deleted & else_)
which simplifies tothen_ | (if not deleted & else_)
This implementation can be confusing because the
then_
branch is always applied, regardless of the record's deletion status. A more consistent implementation, proposed in this pull request, changes this to:(if deleted & then_) | (if not deleted & else_)
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: