Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IfRecordDeleted: a more precise query for deletion status #1968

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mesemus
Copy link
Contributor

@mesemus mesemus commented Mar 1, 2025

Description

The query_filter of IfRecordDeleted(then_, else_) is implemented as:

(match_all & then_) | (if not deleted & else_) which simplifies to then_ | (if not deleted & else_)

This implementation can be confusing because the then_ branch is always applied, regardless of the record's deletion status. A more consistent implementation, proposed in this pull request, changes this to:

(if deleted & then_) | (if not deleted & else_)

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@mesemus mesemus force-pushed the contribution-if-record-deleted-search branch from 9b9b275 to fc26970 Compare March 1, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant