Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create new REST API to support HttpKVStore #5149

Open
kodemartin opened this issue Feb 3, 2025 · 1 comment · May be fixed by #5274
Open

Create new REST API to support HttpKVStore #5149

kodemartin opened this issue Feb 3, 2025 · 1 comment · May be fixed by #5274
Assignees
@sergiupopescu199
Labels
infrastructure Issues related to the Infrastructure Team

Comments

@kodemartin
Copy link
Contributor

Description

HttpKVStore enables a fallback mechanism to fetch historical data from the node.

However it requires a service supporting all the requests that can be inferred from HttpKVStore.get_url

iota/crates/iota-storage/src/http_key_value_store.rs

Lines 144 to 151 in a2a18ac

fn get_url(&self, key: &Key) -> IotaResult<Url> {
let (digest, item_type) = key_to_path_elements(key)?;
let joined = self
.base_url
.join(&format!("{}/{}", digest, item_type))
.into_iota_result()?;
Url::from_str(joined.as_str()).into_iota_result()
}

and

iota/crates/iota-storage/src/http_key_value_store.rs

Line 99 in a2a18ac

fn key_to_path_elements(key: &Key) -> IotaResult<(String, &'static str)> {

Backend

On the backend the services should be able to connect to the remote stores that the respective ingestion pipeline uses. See iota_data_ingestion::kv_store.
@kodemartin kodemartin added the infrastructure Issues related to the Infrastructure Team label Feb 3, 2025
@kodemartin kodemartin mentioned this issue Feb 3, 2025
Open
@kodemartin
Copy link
Contributor Author

@sergiupopescu199 please also consider the changes to be implemented with #5194.

This was referenced Feb 5, 2025
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergiupopescu199 sergiupopescu199

Labels
infrastructure Issues related to the Infrastructure Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create new REST API to support HttpKVStore iotaledger/iota
2 participants
@kodemartin @sergiupopescu199