-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new REST API to support HttpKVStore #5274
Conversation
… CheckpointSummary - This is because the HttpKVStore, when fetching the checkpoint summary, expects a CertifiedCheckpointSummary when deserializing
…kpointContentsByDigest query
* Events by event digests
…serialization of TransactionEvents
# Conflicts: # crates/iota-json-rpc/src/authority_state.rs
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
aws-config = "1.5.6" | ||
aws-sdk-dynamodb = "1.42" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are those those crates not part of the root workspace btw?
I can find them in several crates. Maybe @iotaledger/dev-tools knows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering the same thing, if needed I can make them part of the root workspace, let me know @muXxer @iotaledger/dev-tools
Co-authored-by: muXxer <[email protected]>
Co-authored-by: muXxer <[email protected]>
Co-authored-by: muXxer <[email protected]>
Co-authored-by: muXxer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sergiupopescu199, I would like to ask you to split the PR into smaller patches distinguishing between scopes:
- One for the refactoring of
iota-data-ingestion
- One for the REST service
- One for the docker configuration.
This will allow for more focused and detailed reviews on each scope, by the respective stakeholders each time.
Description of change
iota-rest-kv
to accomodate the REST API implementationKvStoreWorker
iniota-data-ingestion
to reflect the changes made in these PRs:iota-rest-kv
Links to any relevant issues
fixes #5149
Type of change
How the change has been tested
The REST API server relies on several external components
Start Localstack
start the IOTA Node
KvStoreWorker in data ingestion pipeline
KvStoreWorker
process_checkpoint function by adding some debug prints to visualize the various transactions digests & checkpoint digests it saves into DynamoDBdev-tools/iota-data-ingestion
directorydocker-compose.yaml
file to use thekv_store_config.yaml
config filedev-tools/iota-data-ingestion
more info in theREADME.md
start the Kv Store REST API
dev-tools/iota-rest-kv
directorydev-tools/iota-rest-kv
more info in theREADME.md
Execute tests using HttpKvStore
Change checklist