Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iota-indexer)!: enable analytical indexer in iota start #5255

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Thoralf-M
Copy link
Member

Description of change

Make it possible to start the analytical_worker in start_test_indexer_impl and start it when iota start --with-indexer is used

Links to any relevant issues

Fixes #5102

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How the change has been tested

Running cargo run --features=indexer start --force-regenesis --with-faucet --with-indexer and then after ~1 minute with faucet requests

curl http://localhost:9124 \
--header 'content-type: application/json' \
--data '{
  "jsonrpc": "2.0",
  "id": 1,
  "method": "iotax_getNetworkMetrics",
  "params": []
}'
{"jsonrpc":"2.0","id":1,"result":{"currentTps":17.621145374449338,"tps30Days":26.08695652173913,"totalPackages":"5","totalAddresses":"18446744073709551615","totalObjects":"133","currentEpoch":"1","currentCheckpoint":"261"}}

@Thoralf-M Thoralf-M requested review from a team as code owners February 6, 2025 18:14
Copy link

vercel bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
apps-backend ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 1:52pm
apps-ui-kit ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 1:52pm
rebased-explorer ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 1:52pm
wallet-dashboard ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 1:52pm

@iota-ci iota-ci added dev-tools Issues related to the Developer Tools Team sc-platform Issues related to the Smart Contract Platform group. labels Feb 6, 2025
@@ -95,14 +96,15 @@ pub async fn start_test_indexer_impl(
fullnode_sync_worker: true,
rpc_server_worker: false,
data_ingestion_path,
analytical_worker: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it have any effect?
Seems to me that this flag is not checked by any code downstream from here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah no, that was my first attempt, but I also noticed that this doesn't change anything

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed again in 4d3e7df

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-tools Issues related to the Developer Tools Team sc-platform Issues related to the Smart Contract Platform group.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Analytical indexer not started by iota start
4 participants