-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iota-indexer)!: enable analytical indexer in iota start #5255
base: develop
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
@@ -95,14 +96,15 @@ pub async fn start_test_indexer_impl( | |||
fullnode_sync_worker: true, | |||
rpc_server_worker: false, | |||
data_ingestion_path, | |||
analytical_worker: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it have any effect?
Seems to me that this flag is not checked by any code downstream from here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah no, that was my first attempt, but I also noticed that this doesn't change anything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed again in 4d3e7df
Description of change
Make it possible to start the analytical_worker in start_test_indexer_impl and start it when
iota start --with-indexer
is usedLinks to any relevant issues
Fixes #5102
Type of change
How the change has been tested
Running
cargo run --features=indexer start --force-regenesis --with-faucet --with-indexer
and then after ~1 minute with faucet requests