feat(protocol): PCR-2 iota-rest-api #5276
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
muXxer
requested changes
Feb 7, 2025
| @@ -121,7 +121,11 @@ pub struct SystemStateSummary { | |||
| /// during safe mode. | |||
| #[serde_as(as = "iota_types::iota_serde::BigInt<u64>")] | |||
| #[schemars(with = "crate::_schemars::U64")] | |||
| pub safe_mode_computation_rewards: u64, | |||
| pub safe_mode_computation_charges: u64, | |||
| /// Amount of burned computation rewards accumulated during safe mode. | |||
There was a problem hiding this comment.
Suggested change
| /// Amount of burned computation rewards accumulated during safe mode. | |
| /// Amount of burned computation charges accumulated during safe mode. |
muXxer
requested changes
Feb 7, 2025
| @@ -4054,11 +4125,16 @@ | |||
| "description": "Whether the system is running in a downgraded safe mode due to a non-recoverable bug. This is set whenever we failed to execute advance_epoch, and ended up executing advance_epoch_safe_mode. It can be reset once we are able to successfully execute advance_epoch.", | |||
| "type": "boolean" | |||
| }, | |||
| "safe_mode_computation_rewards": { | |||
| "safe_mode_computation_charges": { | |||
| "description": "Amount of computation rewards accumulated (and not yet distributed) during safe mode.", | |||
| "description": "Amount of computation rewards accumulated (and not yet distributed) during safe mode.", | ||
| "type": "string", | ||
| "format": "u64" | ||
| }, | ||
| "safe_mode_computation_charges_burned": { | ||
| "description": "Amount of burned computation rewards accumulated during safe mode.", |
There was a problem hiding this comment.
Suggested change
| "description": "Amount of burned computation rewards accumulated during safe mode.", | |
| "description": "Amount of burned computation charges accumulated during safe mode.", |
| @@ -121,7 +121,11 @@ pub struct SystemStateSummary { | |||
| /// during safe mode. | |||
There was a problem hiding this comment.
one line above rewards should be charges
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.