-
-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add orangetv.es provider #2485
Add orangetv.es provider #2485
Conversation
…inones/epg into orangetv.orange.es
Seems like you've got inspired from the telenet.tv website. A few quacks on my side that i'm solving. |
yeah I took some inspiration from that and the pick.be provider. |
Btw thanks for helping out with the tests. |
That's weird since I have it working. I might have made a copy paste error. |
However I'm afraid there might be some duplicate ítems in the program array. Tbh the way it's made is quite inefficient. A first requests is send to an URL, and aftherwards 3 more requests are send. |
Well, on my side, the code works quite well. The EPG looks good on my side, though there's one single test failing. I've managed to fix one, though one test is failing. |
Works fine on my watch now, both programs and tests. Example piece of data :
Program grabbing :
Tests :
|
I'll let everyone test the current code as-is, and if it is positive for everyone, @davidclaeysquinones you'll be free to make it R2R. |
By the way, I see that #TODO in readme contains this :
The Runtime channels are FAST channels. They can be categorised the same as the Pluto.tv ones. Gametoon is actually registered : http://www.gametoon.com/ / Gametoon.nl https://www.navarratelevision.es/AppParrilla.aspx?canal=Canal2 |
I forgot about that issue but there were quite some channels where I didn't know what I should do with them. The Gametoon one seemed weird because I doubted they were going to transmit a dutch channel in Spain. The channel grabber spit outs also a bunch of other channels, but there is not programs to be found for them. I suspect depending on the region they put the local channels in a dedicated feed. |
I've updated some runtime channels although I haven't found an alternative for all of them. |
I see what you've did, though I think there was a confusion. When I meant that "Runtime channels can be classified the same as Pluto.tv channels", I meant that since the Pluto TV channels exist, there's a place to add Runtime channels in the database. Actually, we do have 2 Runtime channels available. |
That was was pretty stupid of me. I've received the advice to use a bot to do it but I have no clue. |
I have made a PR with the additional channels |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace orangetv.es
with the real domain orangetv.orange.es
.
I renamed the provider to the real domain |
I made the code based on a proposal from @fraudiay79 in this thread.
I've made some improvements and made sure the code performs at a basic level.
Currently this PR is NOT ready to be merged. I've made it in order to get valuable feedback and maybe get some help with it.
I've made some tests but these are not ready for prime time, some API mocking needs to be implemented for that.
Furthermore the channels list needs to be cleaned up, since some channels appear as available but don't have any programs available.
Also the possibility exists that there is still some glaring issue in the code I've looked over.
@BellezaEmporium @PopeyeTheSai10r Would you be willing to have a look at it in order to provide some feedback?