Wrangle warnings (#960)

* un-pub some statics that don't have to be pub to fix build under deny(warnings) * Add allow() for const impl pattern that causes false positives in a rustc lint in derive macros; rust-lang/rust#120363
iqlusioninc · Jan 20, 2025 · e8e3270 · e8e3270
1 parent 091c84d
commit e8e3270
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 2 deletions.
diff --git a/cli/tests/app/exit_status.rs b/cli/tests/app/exit_status.rs
@@ -6,7 +6,7 @@
 use abscissa_core::testing::CmdRunner;
 use once_cell::sync::Lazy;
 
-pub static RUNNER: Lazy<CmdRunner> = Lazy::new(|| CmdRunner::default());
+static RUNNER: Lazy<CmdRunner> = Lazy::new(|| CmdRunner::default());
 
 #[test]
 fn no_args() {

diff --git a/cli/tests/generate_app.rs b/cli/tests/generate_app.rs
@@ -19,7 +19,7 @@ const TEST_COMMANDS: &[&str] = &[
     "clippy",
 ];
 
-pub static RUNNER: Lazy<CmdRunner> = Lazy::new(|| {
+static RUNNER: Lazy<CmdRunner> = Lazy::new(|| {
     let mut runner = CmdRunner::new("cargo");
     runner.exclusive();
     runner

diff --git a/derive/src/command.rs b/derive/src/command.rs
@@ -9,6 +9,8 @@ pub fn derive_command(s: Structure<'_>) -> TokenStream {
     let subcommand_usage = quote!();
 
     s.gen_impl(quote! {
+        #[allow(unknown_lints)]
+        #[allow(non_local_definitions)]
         gen impl Command for @Self {
             #[doc = "Name of this program as a string"]
             fn name() -> &'static str {
@@ -44,6 +46,8 @@ mod tests {
             expands to {
                 #[allow(non_upper_case_globals)]
                 const _DERIVE_Command_FOR_MyCommand: () = {
+                    #[allow(unknown_lints)]
+                    #[allow(non_local_definitions)]
                     impl Command for MyCommand {
                         #[doc = "Name of this program as a string"]
                         fn name() -> & 'static str {
@@ -79,6 +83,8 @@ mod tests {
             expands to {
                 #[allow(non_upper_case_globals)]
                 const _DERIVE_Command_FOR_MyCommand: () = {
+                    #[allow(unknown_lints)]
+                    #[allow(non_local_definitions)]
                     impl Command for MyCommand {
                         #[doc = "Name of this program as a string"]
                         fn name() -> & 'static str {

diff --git a/derive/src/component.rs b/derive/src/component.rs
@@ -13,6 +13,8 @@ pub fn derive_component(s: Structure<'_>) -> TokenStream {
     let dependency_methods = attrs.dependency_methods();
 
     s.gen_impl(quote! {
+        #[allow(unknown_lints)]
+        #[allow(non_local_definitions)]
         gen impl<A> Component<A> for @Self
         where
             A: #abscissa_core::Application
@@ -199,6 +201,8 @@ mod tests {
             expands to {
                 #[allow(non_upper_case_globals)]
                 const _DERIVE_Component_A_FOR_MyComponent: () = {
+                    #[allow(unknown_lints)]
+                    #[allow(non_local_definitions)]
                     impl<A> Component<A> for MyComponent
                     where
                         A: abscissa_core::Application

diff --git a/derive/src/runnable.rs b/derive/src/runnable.rs
@@ -7,6 +7,8 @@ pub fn derive_runnable(s: synstructure::Structure<'_>) -> proc_macro2::TokenStre
     });
 
     s.gen_impl(quote! {
+        #[allow(unknown_lints)]
+        #[allow(non_local_definitions)]
         gen impl Runnable for @Self {
             fn run(&self) {
                 match *self { #body }
@@ -33,6 +35,8 @@ mod tests {
             expands to {
                 #[allow(non_upper_case_globals)]
                 const _DERIVE_Runnable_FOR_MyRunnable: () = {
+                    #[allow(unknown_lints)]
+                    #[allow(non_local_definitions)]
                     impl Runnable for MyRunnable {
                         fn run(&self) {
                             match *self {