-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/typescript with ci/cd #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've highlighted a few minor details in the code, mostly in terms of naming things.
Configuration
I see you're using multiple locations to define your configuration.
- Jest -> package.json
- husky -> package.json
- eslint -> seperate config.
- prettier -> seperate config.
Might I suggest choosing one pattern and sticking with that pattern? That way new developers might find the config they're looking for somewhat faster. IMHO, I believe seperate configurations are the way to go. They can mostly also be defined as a JS file which can be exported as a node module and then on it's turn you can use JS to enhance your configuration if needed.
…iles, split ts config
Adding CI/CD support with unittesting, linting, commitizen, and lint-staged to the project.
All issues raised within the reviews have been dealt with.