Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/typescript with ci/cd #3

Merged
merged 14 commits into from
Apr 21, 2020

Conversation

ronaldvandenbroek
Copy link
Collaborator

@ronaldvandenbroek ronaldvandenbroek commented Apr 17, 2020

Adding CI/CD support with unittesting, linting, commitizen, and lint-staged to the project.

All issues raised within the reviews have been dealt with.

Copy link
Contributor

@mrtnvh mrtnvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ronaldvandenbroek,

I've highlighted a few minor details in the code, mostly in terms of naming things.

Configuration
I see you're using multiple locations to define your configuration.

  1. Jest -> package.json
  2. husky -> package.json
  3. eslint -> seperate config.
  4. prettier -> seperate config.

Might I suggest choosing one pattern and sticking with that pattern? That way new developers might find the config they're looking for somewhat faster. IMHO, I believe seperate configurations are the way to go. They can mostly also be defined as a JS file which can be exported as a node module and then on it's turn you can use JS to enhance your configuration if needed.

@ronaldvandenbroek ronaldvandenbroek merged commit 109a1c0 into develop Apr 21, 2020
@ronaldvandenbroek ronaldvandenbroek deleted the feature/typescript-with-ci/cd branch April 21, 2020 07:26
@mrtnvh mrtnvh removed their request for review April 21, 2020 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants