-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency org.springdoc:springdoc-openapi-starter-webmvc-ui to v2.8.4 #586
base: dev
Are you sure you want to change the base?
Conversation
3cae617
to
6f71605
Compare
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe pull request involves a consistent version update of the SpringDoc library across multiple microservices within the project. Specifically, the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
dd39562
to
1be8db7
Compare
38cd318
to
809535e
Compare
c76b498
to
0600c9a
Compare
0600c9a
to
10ff4ec
Compare
a54023a
to
59108b6
Compare
64a856b
to
a383aab
Compare
75d8622
to
1275041
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (1)
wls-infomanagement-service/pom.xml (1)
38-38
: Consider coordinating the Spring Boot upgrade across all services.Since this is a microservices architecture with multiple services sharing common dependencies, I recommend:
- First, create a separate PR to upgrade Spring Boot to version 3.4.0 across all services
- Then, proceed with this PR to upgrade springdoc-openapi-starter-webmvc-ui to version 2.8.3
This approach helps maintain consistency and prevents potential compatibility issues.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (12)
wls-admin-service/pom.xml
(1 hunks)wls-auth-service/pom.xml
(1 hunks)wls-basisdaten-service/pom.xml
(1 hunks)wls-briefwahl-service/pom.xml
(1 hunks)wls-broadcast-service/pom.xml
(1 hunks)wls-eai-service/pom.xml
(1 hunks)wls-ergebnismeldung-service/pom.xml
(1 hunks)wls-infomanagement-service/pom.xml
(1 hunks)wls-monitoring-service/pom.xml
(1 hunks)wls-vorfaelleundvorkommnisse-service/pom.xml
(1 hunks)wls-wahlvorbereitung-service/pom.xml
(1 hunks)wls-wahlvorstand-service/pom.xml
(1 hunks)
🔇 Additional comments (10)
wls-eai-service/pom.xml (1)
37-37
: Version incompatibility with Spring Boot.The springdoc-openapi-starter-webmvc-ui 2.8.3 requires Spring Boot 3.4.0, but this service is using Spring Boot 3.3.5.
wls-briefwahl-service/pom.xml (1)
38-38
: Version incompatibility with Spring Boot.The springdoc-openapi-starter-webmvc-ui 2.8.3 requires Spring Boot 3.4.0, but this service is using Spring Boot 3.3.5.
wls-wahlvorbereitung-service/pom.xml (1)
38-38
: Version incompatibility with Spring Boot.The springdoc-openapi-starter-webmvc-ui 2.8.3 requires Spring Boot 3.4.0, but this service is using Spring Boot 3.3.5.
wls-infomanagement-service/pom.xml (1)
38-38
: Version incompatibility with Spring Boot.The springdoc-openapi-starter-webmvc-ui 2.8.3 requires Spring Boot 3.4.0, but this service is using Spring Boot 3.3.5.
Let's verify if there are any other services that need the Spring Boot version update:
#!/bin/bash # Description: Find all pom.xml files and check their Spring Boot and springdoc versions echo "Checking Spring Boot and springdoc versions in all services..." find . -name "pom.xml" -type f -exec sh -c ' echo "\nChecking {}:" grep -A1 "<spring.boot.version>" {} | head -n 2 grep -A1 "<org.springdoc.version>" {} | head -n 2 ' \;wls-vorfaelleundvorkommnisse-service/pom.xml (1)
38-38
: Skipping review of duplicate changes.The changes in this file are identical to those in wls-broadcast-service/pom.xml and the same compatibility concerns apply.
wls-monitoring-service/pom.xml (1)
38-38
: Skipping review of duplicate changes.The changes in this file are identical to those in wls-broadcast-service/pom.xml and the same compatibility concerns apply.
wls-ergebnismeldung-service/pom.xml (1)
40-40
: Skipping review of duplicate changes.The changes in this file are identical to those in wls-broadcast-service/pom.xml and the same compatibility concerns apply.
wls-basisdaten-service/pom.xml (1)
38-38
: Skipping review of duplicate changes.The changes in this file are identical to those in wls-broadcast-service/pom.xml and the same compatibility concerns apply.
wls-wahlvorstand-service/pom.xml (1)
38-38
:⚠️ Potential issueVerify Spring Boot compatibility before upgrading springdoc-openapi.
The springdoc-openapi v2.8.3 requires Spring Boot 3.4.0, but the project is using Spring Boot 3.3.5. This version mismatch could lead to compatibility issues.
Consider either:
- Upgrading Spring Boot to 3.4.0 first
- Using an older version of springdoc-openapi that's compatible with Spring Boot 3.3.5
Run this script to check the compatibility matrix:
wls-auth-service/pom.xml (1)
38-38
: Maintain consistent Spring Boot compatibility across services.The same compatibility issue exists in the auth service. The springdoc-openapi v2.8.3 requires Spring Boot 3.4.0, but the project is using Spring Boot 3.3.5.
wls-admin-service/pom.xml
Outdated
@@ -36,7 +36,7 @@ | |||
<!-- Version muss mit der in den spring-boot-dependencies bereitgestellten Lombok-Version übereinstimmen --> | |||
<org.projectlombok.lombok.version>1.18.30</org.projectlombok.lombok.version> | |||
<org.projectlombok.mapstructbinding.version>0.2.0</org.projectlombok.mapstructbinding.version> | |||
<org.springdoc.version>2.6.0</org.springdoc.version> | |||
<org.springdoc.version>2.8.3</org.springdoc.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version incompatibility with Spring Boot.
The springdoc-openapi-starter-webmvc-ui 2.8.3 requires Spring Boot 3.4.0, but this service is using Spring Boot 3.3.5. Please update the Spring Boot version to 3.4.0 to ensure compatibility.
Apply this diff to update the Spring Boot version:
- <spring.boot.version>3.3.5</spring.boot.version>
+ <spring.boot.version>3.4.0</spring.boot.version>
Committable suggestion skipped: line range outside the PR's diff.
wls-broadcast-service/pom.xml
Outdated
@@ -35,7 +35,7 @@ | |||
<org.projectlombok.lombok.version>1.18.30</org.projectlombok.lombok.version> | |||
<org.projectlombok.mapstructbinding.version>0.2.0</org.projectlombok.mapstructbinding.version> | |||
<org.mapstruct.version>1.6.3</org.mapstruct.version> | |||
<org.springdoc.version>2.6.0</org.springdoc.version> | |||
<org.springdoc.version>2.8.3</org.springdoc.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Spring Boot version upgrade required for springdoc-openapi compatibility
The version incompatibility is confirmed. The project uses Spring Boot 3.3.5, but springdoc-openapi v2.8.3 requires Spring Boot ≥3.4.0 (currently using 3.4.1 in its parent POM). Please upgrade the Spring Boot version to at least 3.4.0 to ensure compatibility.
🔗 Analysis chain
Verify Spring Boot version compatibility.
The current Spring Boot version (3.3.5) is lower than the required version (3.4.0) for springdoc-openapi-starter-webmvc-ui v2.8.3. This version mismatch might lead to compatibility issues.
Run the following script to check the compatibility matrix and available versions:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check springdoc and Spring Boot version compatibility
# Check springdoc releases for compatibility information
echo "Checking springdoc releases..."
curl -s "https://api.github.com/repos/springdoc/springdoc-openapi/releases/tags/v2.8.3" | jq -r '.body'
# Check if Spring Boot 3.4.0 is released
echo -e "\nChecking Spring Boot releases..."
curl -s "https://repo1.maven.org/maven2/org/springframework/boot/spring-boot/maven-metadata.xml" | grep -A 1 "<versions>"
Length of output: 618
Script:
#!/bin/bash
# Description: Check springdoc dependencies and Spring Boot versions
# Check springdoc pom.xml for Spring Boot version requirement
echo "Checking springdoc pom.xml..."
curl -s "https://raw.githubusercontent.com/springdoc/springdoc-openapi/v2.8.3/pom.xml" | grep -A 2 "<spring.boot.version>"
# Get recent Spring Boot versions (last 10)
echo -e "\nRecent Spring Boot versions:"
curl -s "https://repo1.maven.org/maven2/org/springframework/boot/spring-boot/maven-metadata.xml" | grep "<version>" | tail -n 10
Length of output: 703
Script:
#!/bin/bash
# Description: Check springdoc Spring Boot dependency with broader search
echo "Checking springdoc pom.xml for Spring Boot dependencies..."
curl -s "https://raw.githubusercontent.com/springdoc/springdoc-openapi/v2.8.3/pom.xml" | grep -B 2 -A 2 "spring-boot"
Length of output: 547
12c7120
to
bbbfb97
Compare
1aaff3a
to
23fe536
Compare
23fe536
to
e764a8a
Compare
This PR contains the following updates:
2.6.0
->2.8.4
Release Notes
springdoc/springdoc-openapi (org.springdoc:springdoc-openapi-starter-webmvc-ui)
v2.8.4
Compare Source
Added
Changed
Fixed
v2.8.3
Compare Source
Added
v2.8.2
Compare Source
Added
Fixed
v2.8.1
Compare Source
Fixed
v2.8.0
Compare Source
Added
Changed
Fixed
v2.7.0
Added
Changed
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.