645 keycloak durch authservice ersetzen #680

MrSebastian · 2025-01-07T11:13:28Z

Beschreibung:

Entfernung von Keycloak und Verwendung Auth-Service

Die Rolle ROLE_ADMIN_ADMIN muss vorhanden da im Auth-Service nicht die Rechte, sondern nur die Rollen zur Verfügung stehen
die User wls_all* erhalten über die Testdaten alle Rechte
die Rechte werden über DB-Migration gepflegt
alle Beispiel-Requests wurden angepasst um mit dem Auth-Service zu arbeiten
- um ein Login zu wiederufen die IntelliJ-Hilfe-Seite beachten
extra Hosts wurden eingefügt damit die Services in Docker auch mit einem Auth-Service in der IDE kommunizieren können
Entfernen der Cookies in Richtung auth-Service ist wichtig da sonst neue Cookies gesetzt werden die dann nicht mehr einem Token im Gateway zugeordnet werden können
es sind die gleichen Benutzer vorhanden wie in Keycloak: wls_all, wls_all_uwb, wls_all_bwb, wls_test

Bekannte Probleme:

Wahlvorbereitung nicht in Docker startbar
- wurde mit 3ed64b2 gefixt, aber danach kein Release gebaut

Definition of Done (DoD):

Backend

Codingconventions beachtet
Doku aktualisiert
Swagger-API vollständig - keine Änderung an API vorgenommen
Unit-Tests gepflegt
Integrationstests gepflegt - auf neue User umgestellt
Beispiel-Requests gepflegt

Referenzen¹:

Closes #654

Summary by CodeRabbit

Based on the comprehensive summary of changes, here are the release notes:

Release Notes

Authentication and Authorization
- Replaced Keycloak-based authentication with a new authentication service
- Removed realm-specific configurations across all services
- Updated OAuth2 endpoints for JWT and user information retrieval
- Standardized Bearer token authorization mechanism
Documentation
- Updated documentation to remove Keycloak-specific references
- Removed migration and realm management sections
- Simplified authentication terminology
Environment Configuration
- Removed Keycloak-related environment variables
- Added new SSO-related environment variables
- Updated Docker Compose configuration to remove Keycloak services
Test Resources
- Updated HTTP request files to use new authentication service
- Simplified token retrieval process
- Standardized authorization headers across services
Database Migrations
- Retained existing user and authority configurations
- Updated permission and role assignments
- Maintained existing user management structures

Nicht zutreffende Referenzen vor dem Speichern entfernen ↩

…h-authservice-ersetzen

…5-keycloak-durch-authservice-ersetzen # Conflicts: # stack/.env

# Conflicts: # stack/http_requests/http-client.env.json

coderabbitai · 2025-01-07T11:13:34Z

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes represent a comprehensive migration from a Keycloak-based authentication system to a more generalized authentication service. The modifications span multiple services and configuration files, removing Keycloak-specific references and replacing them with a new Single Sign-On (SSO) approach. Key changes include updating OAuth2 configuration endpoints, removing realm-specific settings, and standardizing authorization methods across services. The changes affect authentication URIs, token retrieval mechanisms, and user management configurations. Documentation, environment variables, and test resources have been updated to reflect this new authentication strategy.

Assessment against linked issues

Objective	Addressed	Explanation
Backend Coding Conventions	✅	Changes follow consistent patterns across services
Documentation Updated	✅	Configuration and authentication documentation modified
Swagger-API Completeness	❓	Cannot definitively confirm without reviewing Swagger specifications
Unit Tests Maintained	✅	Test resources updated to reflect new authentication mechanism
Integration Tests Maintained	✅	HTTP request files updated with new authentication approach
Example Requests Updated	✅	HTTP request files modified with new token retrieval method

The changes appear to be primarily focused on authentication restructuring and do not directly address the specific requirements of reading and writing voting records (Wahlscheine). While the authentication mechanism has been updated, the implementation details for Wahlscheine management would need further investigation to confirm full compliance with issue #654.

Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary or `` to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai or `` anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

…etzen

…urce_when_loggingInWithToken

# Conflicts: # stack/keycloak/migration/keycloak-changelog.yml permission from pr #663 added

MrSebastian · 2025-01-08T14:25:20Z

@vjohnslhm ich habe die neue Rechte und Beispielanfragen die mit #663 soeben hinzukamen mit aufgenommen bzw. angepasst

vjohnslhm

hab noch ein paar zeilen duplicated code gefunden, ansonsten sieht es jetzt gut aus 👍🏽

...auth-service/src/main/resources/db/migrations/h2/V4_9__insertWahlvorbereitungPermissions.sql

...-service/src/main/resources/db/migrations/oracle/V4_9__insertWahlvorbereitungPermissions.sql

# Conflicts: # stack/.env # stack/docker-compose.yml # wls-admin-service/src/main/resources/application.yml # wls-briefwahl-service/src/main/resources/application.yml # wls-broadcast-service/src/main/resources/application-dev.yml # wls-broadcast-service/src/main/resources/application-kon.yml # wls-broadcast-service/src/main/resources/application-prod.yml # wls-ergebnismeldung-service/src/main/resources/application.yml # wls-infomanagement-service/src/main/resources/application.yml # wls-monitoring-service/src/main/resources/application.yml

stack/.env

vjohnslhm

sieht jetzt gut aus (:

MrSebastian added 24 commits December 17, 2024 09:23

Merge branch 'use-same-ports-local-and-docker' into 645-keycloak-durc…

4461e41

…h-authservice-ersetzen

configure auth service and replace keycloak

ec7dd7a

configure clientid to match dummydata

e7700de

config security and no-security environment

d6d2a78

Merge branch '130-abschluss-für-betrieb-von-wls-service-auth' into 64…

290824c

…5-keycloak-durch-authservice-ersetzen # Conflicts: # stack/.env

add permissions

4452189

replace old users with users used in keycloak

9cf0c80

add ex keycloak users to embedded ldap

8d80650

Merge branch 'dev' into 645-keycloak-durch-authservice-ersetzen

fee80c4

# Conflicts: # stack/http_requests/http-client.env.json

replace keycloak sso urls with auth service values

9ea46a5

remove Cookies from communication with auth-service

8e5b190

fix typo in filename

558fc18

change authority name to match its code requirements

014628e

fix wrong parent element for uri-variables

217d22e

use new port of auth service

0ad1370

fix required clientID in request

0c5e65e

use wls_all-user

3abfbc9

use oauth2-Login in example requests

f83858b

remove http request for keycloak

5dcf4e4

refactor http requests to use auth-service

32fc30f

add gateway to host to all service containers

564f25a

add missing permisisons for begruendung and wahlscheine

8bb9110

use oauth settings in example requests

0b0f3aa

🔥 keycloak migration files and realm import

e70f2ff

MrSebastian self-assigned this Jan 7, 2025

MrSebastian linked an issue Jan 7, 2025 that may be closed by this pull request

Keycloak durch AuthService ersetzen #645

Closed

8 tasks

MrSebastian added 3 commits January 7, 2025 13:12

Merge branch 'refs/heads/dev' into 645-keycloak-durch-authservice-ers…

734cc34

…etzen

fix test to run with changed embedded ldap user

5aed8bc

remove nearly duplicate test to existing test should_accessSecureReso…

2ac11ed

…urce_when_loggingInWithToken

This was referenced Jan 8, 2025

Refactor Docker DB URL - selbe Var in allen Services verwenden #687

Closed

Trennung zwischen Schreib und Lesezugriffsberechtigung #688

Open

MrSebastian added 3 commits January 8, 2025 13:33

👌 improve names of sql statement groups

9b4a7f2

👌 improve request comment

94e4cbb

👌 fix wrong grouping of permissions

18b00bf

MrSebastian mentioned this pull request Jan 8, 2025

zu viele leerzeilen in application*.yml-Dateien #689

Closed

MrSebastian added 2 commits January 8, 2025 14:00

add missing permission

f7f8f8c

fix constraint violation

2c9a000

MrSebastian requested a review from vjohnslhm January 8, 2025 13:04

MrSebastian mentioned this pull request Jan 8, 2025

Update klg71/keycloakmigration Docker tag to v0.2.74 #508

Closed

1 task

MrSebastian added 2 commits January 8, 2025 15:20

Merge branch 'dev' into 645-keycloak-durch-authservice-ersetzen

32012bd

# Conflicts: # stack/keycloak/migration/keycloak-changelog.yml permission from pr #663 added

example request changed to oauth2 usage

5b67966

vjohnslhm requested changes Jan 8, 2025

View reviewed changes

...auth-service/src/main/resources/db/migrations/h2/V4_9__insertWahlvorbereitungPermissions.sql Outdated Show resolved Hide resolved

...-service/src/main/resources/db/migrations/oracle/V4_9__insertWahlvorbereitungPermissions.sql Outdated Show resolved Hide resolved

remove duplicate permission

69179c8

MrSebastian requested a review from vjohnslhm January 8, 2025 17:39

vjohnslhm previously approved these changes Jan 9, 2025

View reviewed changes

MrSebastian dismissed vjohnslhm’s stale review via 3017d2e January 9, 2025 09:27

MrSebastian requested a review from vjohnslhm January 9, 2025 09:28

vjohnslhm requested changes Jan 9, 2025

View reviewed changes

stack/.env Outdated Show resolved Hide resolved

fix merge mistakes

4d883fc

MrSebastian requested a review from vjohnslhm January 9, 2025 12:22

MrSebastian enabled auto-merge January 9, 2025 12:23

vjohnslhm requested changes Jan 9, 2025

View reviewed changes

stack/.env Show resolved Hide resolved

MrSebastian added 2 commits January 9, 2025 15:48

remove keycloak env vars

16ca49a

fix username in doc

290fa85

vjohnslhm approved these changes Jan 9, 2025

View reviewed changes

MrSebastian merged commit 33a15de into dev Jan 9, 2025
17 checks passed

MrSebastian deleted the 645-keycloak-durch-authservice-ersetzen branch January 9, 2025 15:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

645 keycloak durch authservice ersetzen #680

645 keycloak durch authservice ersetzen #680

MrSebastian commented Jan 7, 2025 •

edited

Loading

coderabbitai bot commented Jan 7, 2025 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

MrSebastian commented Jan 8, 2025

vjohnslhm left a comment

vjohnslhm left a comment

645 keycloak durch authservice ersetzen #680

645 keycloak durch authservice ersetzen #680

Conversation

MrSebastian commented Jan 7, 2025 • edited Loading

Beschreibung:

Bekannte Probleme:

Definition of Done (DoD):

Backend

Referenzen1:

Summary by CodeRabbit

Release Notes

Footnotes

coderabbitai bot commented Jan 7, 2025 • edited Loading

Review skipped

Walkthrough

Assessment against linked issues

Finishing Touches

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

MrSebastian commented Jan 8, 2025

vjohnslhm left a comment

Choose a reason for hiding this comment

vjohnslhm left a comment

Choose a reason for hiding this comment

MrSebastian commented Jan 7, 2025 •

edited

Loading

Referenzen¹:

coderabbitai bot commented Jan 7, 2025 •

edited

Loading