Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update ghcr.io/it-at-m/eappointment-php-base docker tag to v8.3 #762

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 10, 2025

This PR contains the following updates:

Package Type Update Change
ghcr.io/it-at-m/eappointment-php-base container minor 8.0-dev -> 8.3-dev
ghcr.io/it-at-m/eappointment-php-base minor 8.0-base -> 8.3-base

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Summary by CodeRabbit

  • Tests
    • Enhanced the unit testing workflow with an updated PHP setup and refined code coverage generation to ensure robust, reliable testing.
  • Chores
    • Upgraded the underlying container images to a more current PHP version, improving performance and overall environment stability.

Copy link
Contributor

coderabbitai bot commented Jan 10, 2025

Walkthrough

This pull request updates the Docker image versions used in the PHP unit testing workflows and docker-compose configuration. The container images for the zmsapi-test and zmsdb-test jobs are updated from version 8.0-dev to 8.3-dev. Additionally, the zmsclient-test job now includes a step to set up PHP using the shivammathur/setup-php@v2 action with PHP version 8.0 and xdebug enabled for coverage. The docker-compose file for the test service is also updated to use the newer image version 8.3-base.

Changes

File(s) Change Summary
.github/workflows/php-unit-tests.yaml - Updated Docker image in zmsapi-test and zmsdb-test jobs from 8.0-dev to 8.3-dev
- Added PHP setup step using shivammathur/setup-php@v2 with PHP 8.0 and xdebug in zmsclient-test
zmsclient/docker-compose.yml - Updated image for the test service from 8.0-base to 8.3-base
- Retained commented volume bindings unchanged

Sequence Diagram(s)

sequenceDiagram
  participant GitHub as GitHub Actions
  participant Setup as PHP Setup Step
  participant Docker as Docker Test Runner
  participant Coverage as Coverage Artifact

  GitHub->>Setup: Start zmsclient-test Job
  Setup->>Docker: Configure PHP (8.0 with xdebug)
  Docker->>GitHub: Run unit tests in container
  Docker->>Coverage: Generate and upload coverage report
Loading

Possibly related PRs

Suggested reviewers

  • tobiasholler

Poem

I’m a hopping rabbit with a tale to share,
Docker images now updated with modern flair,
PHP is set up with precision and care,
Unit tests run smoothly, floating in the air,
I nibble on code and hop with delight,
Celebrating our changes in the moonlit night!
🐇✨


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@renovate renovate bot force-pushed the renovate/ghcr.io-it-at-m-eappointment-php-base-8.x branch from c1d78de to 0c83cb4 Compare February 10, 2025 19:54
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/php-unit-tests.yaml (1)

234-240: Configure PHP Setup in the zmsclient-test Job.
A new step has been added using shivammathur/setup-php@v2 to configure PHP 8.0 with the required extensions (mbstring, xml, ctype, iconv, intl, pdo_mysql) and enable xdebug for coverage. Given that other jobs now run on images tagged with 8.3-dev (or, in one case, are based on the matrix value of 8.0), please review that using PHP 8.0 in this job is intentional and aligns with your testing strategy. If consistency across PHP versions is desired, you might consider revisiting this configuration.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4b35de5 and 0c83cb4.

📒 Files selected for processing (2)
  • .github/workflows/php-unit-tests.yaml (2 hunks)
  • zmsclient/docker-compose.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (3)
zmsclient/docker-compose.yml (1)

17-17: Update Docker Image Tag for the Test Service.
The Docker image tag for the test service has been updated from 8.0-base to 8.3-base. Please confirm that the new base image is fully compatible with your application’s environment and dependencies.

.github/workflows/php-unit-tests.yaml (2)

97-97: Update Container Image for the zmsapi-test Job.
The container image for the zmsapi-test job has been updated to use ghcr.io/it-at-m/eappointment-php-base:8.3-dev. Ensure that this new version supports all required dependencies and that none of the test scripts or configurations break due to the version bump.


165-165: Update Container Image for the zmsdb-test Job.
The container image for the zmsdb-test job is now set to ghcr.io/it-at-m/eappointment-php-base:8.3-dev. Please verify that this update satisfies all compatibility requirements, especially those related to database connectivity and test dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants