-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update ghcr.io/it-at-m/eappointment-php-base docker tag to v8.3 #762
base: next
Are you sure you want to change the base?
Conversation
WalkthroughThis pull request updates the Docker image versions used in the PHP unit testing workflows and docker-compose configuration. The container images for the Changes
Sequence Diagram(s)sequenceDiagram
participant GitHub as GitHub Actions
participant Setup as PHP Setup Step
participant Docker as Docker Test Runner
participant Coverage as Coverage Artifact
GitHub->>Setup: Start zmsclient-test Job
Setup->>Docker: Configure PHP (8.0 with xdebug)
Docker->>GitHub: Run unit tests in container
Docker->>Coverage: Generate and upload coverage report
Possibly related PRs
Suggested reviewers
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
c1d78de
to
0c83cb4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/php-unit-tests.yaml (1)
234-240
: Configure PHP Setup in the zmsclient-test Job.
A new step has been added usingshivammathur/setup-php@v2
to configure PHP 8.0 with the required extensions (mbstring, xml, ctype, iconv, intl, pdo_mysql) and enable xdebug for coverage. Given that other jobs now run on images tagged with8.3-dev
(or, in one case, are based on the matrix value of8.0
), please review that using PHP 8.0 in this job is intentional and aligns with your testing strategy. If consistency across PHP versions is desired, you might consider revisiting this configuration.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/php-unit-tests.yaml
(2 hunks)zmsclient/docker-compose.yml
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (3)
zmsclient/docker-compose.yml (1)
17-17
: Update Docker Image Tag for the Test Service.
The Docker image tag for thetest
service has been updated from8.0-base
to8.3-base
. Please confirm that the new base image is fully compatible with your application’s environment and dependencies..github/workflows/php-unit-tests.yaml (2)
97-97
: Update Container Image for the zmsapi-test Job.
The container image for thezmsapi-test
job has been updated to useghcr.io/it-at-m/eappointment-php-base:8.3-dev
. Ensure that this new version supports all required dependencies and that none of the test scripts or configurations break due to the version bump.
165-165
: Update Container Image for the zmsdb-test Job.
The container image for thezmsdb-test
job is now set toghcr.io/it-at-m/eappointment-php-base:8.3-dev
. Please verify that this update satisfies all compatibility requirements, especially those related to database connectivity and test dependencies.
This PR contains the following updates:
8.0-dev
->8.3-dev
8.0-base
->8.3-base
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.
Summary by CodeRabbit