Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle ip changes #1

Closed
wants to merge 9 commits into from
Closed

Handle ip changes #1

wants to merge 9 commits into from

Conversation

ivan-kripakov-m10
Copy link
Owner

@ivan-kripakov-m10 ivan-kripakov-m10 commented Dec 21, 2023

Pull request is associated with issue distribworks#1442

I made several things here:

  1. add server_lookup and pass it to raft transport layer to provide possibility for ip changing in cluster (id -> ip mapping is updated on serf events)
  2. add serf member update handling
  3. resolve todo Query each of the servers and make sure they report no Raft peers. (I'm not sure if it is correct approach)
  4. Avoid self removing from raft cluster in leader loop because it leads to raft shutdown (on both add [don't remove if server id matches, just update configuration] and remove peer [skip if server id matches with current])

I built image and tested it in k8s using this helm - distribworks/dkron-helm#7
Seems like everything works fine now

@ivan-kripakov-m10
Copy link
Owner Author

dkron is deployed now to feature/try-147

@ivan-kripakov-m10
Copy link
Owner Author

ivan-kripakov-m10 commented Dec 21, 2023

will close this PR in favour of m10-payments#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants