Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make VDOM functions public #102

Merged
merged 3 commits into from
Jan 27, 2025
Merged

Conversation

flosse
Copy link
Contributor

@flosse flosse commented Jan 20, 2025

Motivation:
To be able to manually use the virtual DOM, we need to have access to functions like create_dom_node, apply_dom_patches etc.

Solution:
Decouple the functions from the Program

@flosse flosse marked this pull request as draft January 20, 2025 17:29
@flosse flosse changed the title Make create_dom_node and apply_dom_patches public Make VDOM functions public Jan 20, 2025
@flosse flosse marked this pull request as ready for review January 20, 2025 22:30
@flosse
Copy link
Contributor Author

flosse commented Jan 26, 2025

@qknight I added your test from qknight@2152c5a

Copy link
Owner

@ivanceras ivanceras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ivanceras ivanceras merged commit 679b10c into ivanceras:master Jan 27, 2025
4 checks passed
@ivanceras
Copy link
Owner

Published on crates.io on version 0.70.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants