Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some initial error handling for DEM/DTM #167

Merged
merged 6 commits into from
Jan 21, 2025
Merged

Conversation

kbrandwijk
Copy link
Collaborator

@kbrandwijk kbrandwijk commented Jan 21, 2025

Tweaked DEM/DTM error handling a bit as per our discussion:

  • Display user-facing error string to the user
  • Don't swallow DEM processing errors, but log and rethrow instead
  • Add initial error handling to some DTM providers:
    • Check if API key is provided for Finland
    • Check if token is provided for Denmark
  • Refactor extents logic to allow for multiple extents to define a DTM provider and add correct ones for France

@kbrandwijk kbrandwijk requested a review from iwatkot January 21, 2025 14:50
@kbrandwijk kbrandwijk added the Refactoring Nothing fancy, just sweat and blood. label Jan 21, 2025
@iwatkot
Copy link
Owner

iwatkot commented Jan 21, 2025

@kbrandwijk, I recommend removing the webui/generator from the PR since you have like three symbols changed there. But you can go the hard way and merge the main. 🤣

webui/generator.py Outdated Show resolved Hide resolved
@kbrandwijk
Copy link
Collaborator Author

Rebased

@kbrandwijk kbrandwijk requested a review from iwatkot January 21, 2025 17:24
@iwatkot iwatkot merged commit 783810e into main Jan 21, 2025
3 checks passed
@iwatkot iwatkot deleted the kim/dem-error-handling branch January 21, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactoring Nothing fancy, just sweat and blood.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants