Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the react-redux version #2535

Closed

Conversation

kunal-511
Copy link

@kunal-511 kunal-511 commented Jan 3, 2025

Which problem is this PR solving?

Description of the changes

  • Which problem is this PR solving?
    Description of the changes
    Update the react-redux and redux to its latest version .

How was this change tested?

Checklist

@kunal-511 kunal-511 requested a review from a team as a code owner January 3, 2025 06:45
@kunal-511 kunal-511 requested review from pavolloffay and removed request for a team January 3, 2025 06:45
@kunal-511 kunal-511 force-pushed the fix-2530-react-redux-update branch from 7cbf1f5 to 84f8a7c Compare January 3, 2025 06:45
@yurishkuro
Copy link
Member

You ticked the checkbox npm run lint and npm run test but all the tests and lints are failing.

@kunal-511 kunal-511 force-pushed the fix-2530-react-redux-update branch from 2807bf1 to da633f4 Compare January 4, 2025 07:27
@kunal-511
Copy link
Author

You ticked the checkbox npm run lint and npm run test but all the tests and lints are failing.

I have added commit to fix them. Please check

Copy link

codecov bot commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.63%. Comparing base (9feb3bd) to head (da633f4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2535   +/-   ##
=======================================
  Coverage   96.63%   96.63%           
=======================================
  Files         255      255           
  Lines        7728     7728           
  Branches     2002     1950   -52     
=======================================
  Hits         7468     7468           
  Misses        260      260           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro
Copy link
Member

@kunal-511 thanks for PR, but I accepted #2537 which was more concise. Feel free to try other upgrades that we still need to make.

@yurishkuro yurishkuro closed this Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:dependencies Update to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Deps]: Upgrade react-redux to 9.x
2 participants