rotateSingleLog: free savedContext when setSecCtxByName fails

``` Error: RESOURCE_LEAK (CWE-772): logrotate-3.18.0/logrotate.c:2032: alloc_arg: "setSecCtxByName" allocates memory that is stored into "savedContext". logrotate-3.18.0/logrotate.c:2034: leaked_storage: Variable "savedContext" going out of scope leaks the storage it points to. ```
jamacku · Mar 14, 2024 · 7f8324a · 7f8324a
1 parent dd31599
commit 7f8324a
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/logrotate.c b/logrotate.c
@@ -2146,6 +2146,7 @@ static int rotateSingleLog(const struct logInfo *log, unsigned logNum,
         if (!(log->flags & (LOG_FLAG_COPYTRUNCATE | LOG_FLAG_COPY))) {
             if (setSecCtxByName(log->files[logNum], log, &savedContext) != 0) {
                 /* error msg already printed */
+                freecon(savedContext);
                 return 1;
             }
 #ifdef WITH_ACL