Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default API keys to credentials #66

Closed
wants to merge 1 commit into from

Conversation

epenet
Copy link
Contributor

@epenet epenet commented May 17, 2020

Implement #54

@jamesremuscat
Copy link
Owner

I'm not going to merge this.

Not having those keys included in this repository is deliberate: I can then say "pyze does not contain Renault's private API keys". Though at this point I doubt anyone from Renault cares, I'd still prefer to have that as a fallback position.

#54 specifically talked about "the getting of the api-keys into pyze automatically" - e.g. a mechanism for pyze to retrieve the keys from Renault's server where they're (still) publishing them.

@epenet epenet deleted the API-keys branch June 1, 2020 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants