Merge pull request #149 from janpfeifer/stacktrace

Added stack traces to protocol error messages.
janpfeifer · Jan 19, 2025 · 7169983 · 7169983
2 parents 2c8d5b3 + 0b2a8a2
commit 7169983
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
@@ -5,6 +5,7 @@
 * Improved `autostart` logic: it now requires being mounted as "readonly" under `/root/autostart`.
 * Added `%version`, and environment variables `GONB_VERSION`, `GONB_GIT_COMMIT`.
 * Added `%help` info on missing environment variables.
+* Added stack traces to protocol parsing errors.
 
 ## v0.10.6, 2024/10/16, Improved Docker, added `%capture`
 

diff --git a/internal/kernel/kernel.go b/internal/kernel/kernel.go
@@ -520,11 +520,11 @@ func (k *Kernel) FromWireMsg(zmqMsg zmq4.Msg) Message {
 		signature := make([]byte, hex.DecodedLen(len(parts[i+1])))
 		_, err := hex.Decode(signature, parts[i+1])
 		if err != nil {
-			m.err = errors.WithMessagef(&InvalidSignatureError{}, "while decoding received message")
+			m.err = errors.Wrapf(&InvalidSignatureError{}, "while hex-decoding received message")
 			return m
 		}
 		if !hmac.Equal(mac.Sum(nil), signature) {
-			m.err = errors.WithMessagef(&InvalidSignatureError{}, "invalid signature of received message, doesn't match secret key used during initialization")
+			m.err = errors.Wrapf(&InvalidSignatureError{}, "invalid check sum of received message, doesn't match secret key used during initialization")
 			return m
 		}
 	}
@@ -533,22 +533,22 @@ func (k *Kernel) FromWireMsg(zmqMsg zmq4.Msg) Message {
 	var err error
 	err = json.Unmarshal(parts[i+2], &m.Composed.Header)
 	if err != nil {
-		m.err = errors.WithMessagef(err, "while decoding ComposedMsg.Header")
+		m.err = errors.Wrapf(err, "while decoding ComposedMsg.Header")
 		return m
 	}
 	err = json.Unmarshal(parts[i+3], &m.Composed.ParentHeader)
 	if err != nil {
-		m.err = errors.WithMessagef(err, "while decoding ComposedMsg.ParentHeader")
+		m.err = errors.Wrapf(err, "while decoding ComposedMsg.ParentHeader")
 		return m
 	}
 	err = json.Unmarshal(parts[i+4], &m.Composed.Metadata)
 	if err != nil {
-		m.err = errors.WithMessagef(err, "while decoding ComposedMsg.Metadata")
+		m.err = errors.Wrapf(err, "while decoding ComposedMsg.Metadata")
 		return m
 	}
 	err = json.Unmarshal(parts[i+5], &m.Composed.Content)
 	if err != nil {
-		m.err = errors.WithMessagef(err, "while decoding ComposedMsg.Content")
+		m.err = errors.Wrapf(err, "while decoding ComposedMsg.Content")
 		return m
 	}
 	return m