Add Hey Calendar Support #47

davidos16 · 2024-05-07T17:10:08Z

Updated to include integrating with Hey, (Hey.com), an email and calendar service from the 37 Signals team. This fits in with the rest of the export functionality allowing you to specify a "hey_url" to export the event.

Add hey_url to integrate with hey calendar from 37 signals. hey.com

Update add_to_calendar.rb

Fix hey url generation

Hey Calendar fix

jorgemanrubia

Thanks for working on this @davidos16!

jorgemanrubia · 2024-05-08T07:36:03Z

lib/add_to_calendar.rb

@@ -27,6 +27,30 @@ def initialize(start_datetime:, end_datetime: nil, title:, timezone:, location:

      validate_attributes
    end
+
+    def hey_url
+      calendar_url = "https://app.hey.com/calendar/ical_events/new?ical_source=BEGIN%3AVCALENDAR%0AVERSION%3A2.0%0APRODID%3A-%2F%2FBasecamp%2F%2FBC3%2F%2FEN%0ACALSCALE%3AGREGORIAN%0A%0ABEGIN%3AVEVENT"


PRODID probably shouldn't be "Basecamp", but the product where this link is added to. It's Basecamp in the example link I sent you because it's a link extracted from Basecamp.

jorgemanrubia · 2024-05-08T07:38:25Z

lib/add_to_calendar.rb

+      end
+
+      calendar_url << "%0AEND%3AVEVENT%0AEND%3AVCALENDAR"
+      return calendar_url


To build the URL with the query, you could build the ical source as regular text and then do:

query = URI.encode_www_form(ical_source: ical_source) "https://app.hey.com/calendar/ical_events/new?#{query}"

So that you don't have to care about escaping characters and such.

Thanks @jorgemanrubia I'm having issues using the URI.encode_www_form. Tried to get some hints but I'm unfortunately can't get it to print the params out separated with %0A. Any hint you can give me around how you do in BC?

jaredlt · 2024-05-08T10:02:31Z

@davidos16 thank you for working on this! Love the feature and I’ll be happy to merge it. Two things:

Would you mind adding a few tests? Just to confirm things are working as expected and so I don’t break anything in the future :)
I’m on holiday at the moment, happily without my laptop! Hope you don’t mind, but I’ll come back to this, give it a proper review and move it forward in 1-2 weeks (bit vague, sorry. Just depends how busy I am once I return from holiday)

davidos16 · 2024-05-11T12:38:42Z

lib/add_to_calendar.rb

+
+    def hey_url
+      calendar_url = "https://app.hey.com/calendar/ical_events/new?ical_source=BEGIN%3AVCALENDAR%0ABEGIN%3AVEVENT"
+


@jorgemanrubia Ty! moved too fast, updated the initial calendar URL moving out the prodid.

davidos16 · 2024-05-11T12:43:16Z

@davidos16 thank you for working on this! Love the feature and I’ll be happy to merge it. Two things:

Would you mind adding a few tests? Just to confirm things are working as expected and so I don’t break anything in the future :)

I’m on holiday at the moment, happily without my laptop! Hope you don’t mind, but I’ll come back to this, give it a proper review and move it forward in 1-2 weeks (bit vague, sorry. Just depends how busy I am once I return from holiday)

No rush, and ty!

Hoping to get my first open source pr, so please lmk any updates or tips to be better in the future.

Still fixing a few tests, fyi.

jaredlt

@davidos16 I'm really sorry I haven't got back to you on this. I've been dealing with some family stuff and haven't had the time.

Left a couple of tiny comments. Some other thoughts:

I don't have access to Hey Calendar so I wanted to confirm if you have tested this manually and all is working well? Including a bunch of variations eg.
- with/without end date
- url shows in description
- all day works as expected
- adding organizer doesn't break anything
- probably some other scenarios you have in the test cases
A bunch of the tests are failing but I think that's because of daylight savings (and the way I've implemented all the tests, which you've just copied 🙃 ). I really need to refactor all the tests to work on fixed dates but that's outside the scope of this PR.

I unfortunately won't have a lot of time in the next week or two but hopefully after that I can properly can back to things and we can work to get this merged!

jaredlt · 2024-06-21T14:58:48Z

lib/add_to_calendar.rb

+        if add_url_to_description && url
+          if params[:DESCRIPTION]
+            params[:DESCRIPTION] << "\\n\\n#{url_encode(url)}"
+          else
+            params[:DESCRIPTION] = url_encode(url)
+          end
+        end


Just aligning this with the rest of the indentation

Suggested change

if add_url_to_description && url

if params[:DESCRIPTION]

params[:DESCRIPTION] << "\\n\\n#{url_encode(url)}"

else

params[:DESCRIPTION] = url_encode(url)

end

end

if add_url_to_description && url

if params[:DESCRIPTION]

params[:DESCRIPTION] << "\\n\\n#{url_encode(url)}"

else

params[:DESCRIPTION] = url_encode(url)

end

end

jaredlt · 2024-06-21T15:00:38Z

lib/add_to_calendar/version.rb

@@ -1,3 +1,3 @@
 module AddToCalendar
-  VERSION = "0.4.0"
+  VERSION = "0.4.1"


I think this is a new feature worthy of a minor version bump :)

Suggested change

VERSION = "0.4.1"

VERSION = "0.5.0"

jared-thoughtbot · 2024-09-14T16:05:38Z

I couldn't update this PR so I created a new one here which resolves all the issues around encoding, same day events and the tests. #52

jared-thoughtbot · 2024-09-18T11:16:56Z

Closing as resolved by #52. v0.5.0 is released with Hey Calendar support. Thank you for taking on the initiative!

davidos16 added 5 commits May 7, 2024 11:33

Update add_to_calendar.rb

11c76c5

Add hey_url to integrate with hey calendar from 37 signals. hey.com

Merge pull request #1 from davidos16/Add-Hey-Calendar-Support

348490e

Update add_to_calendar.rb

Update add_to_calendar.rb

b16e9ed

Fix hey url generation

Update add_to_calendar.rb

0e254fd

Hey Calendar fix

Update version.rb

36342dd

jorgemanrubia reviewed May 8, 2024

View reviewed changes

davidwayfinder added 10 commits May 8, 2024 12:36

update and test hey urL method for test"

2b38774

update and hey_url method

9b16f51

fix ical source

4998a84

flatten params

108d479

fix return query

ad213f2

fix query end

2bc14de

fix hey url method name and url return

4eec71f

add additional params based on hey aurl

12b2c54

draft update with testing

484b2df

remove require uri

3aef9c9

davidos16 commented May 11, 2024

View reviewed changes

davidos16 requested a review from jorgemanrubia May 16, 2024 12:36

jaredlt reviewed Jun 21, 2024

View reviewed changes

jared-thoughtbot mentioned this pull request Sep 14, 2024

Hey URL manual testing #51

Closed

9 tasks

jared-thoughtbot closed this Sep 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Hey Calendar Support #47

Add Hey Calendar Support #47

davidos16 commented May 7, 2024

jorgemanrubia left a comment

jorgemanrubia May 8, 2024

jorgemanrubia May 8, 2024

davidos16 May 11, 2024

jaredlt commented May 8, 2024

davidos16 May 11, 2024

davidos16 commented May 11, 2024

jaredlt left a comment

jaredlt Jun 21, 2024

jaredlt Jun 21, 2024

jared-thoughtbot commented Sep 14, 2024

jared-thoughtbot commented Sep 18, 2024


		def hey_url
		calendar_url = "https://app.hey.com/calendar/ical_events/new?ical_source=BEGIN%3AVCALENDAR%0ABEGIN%3AVEVENT"

Add Hey Calendar Support #47

Add Hey Calendar Support #47

Conversation

davidos16 commented May 7, 2024

jorgemanrubia left a comment

Choose a reason for hiding this comment

jorgemanrubia May 8, 2024

Choose a reason for hiding this comment

jorgemanrubia May 8, 2024

Choose a reason for hiding this comment

davidos16 May 11, 2024

Choose a reason for hiding this comment

jaredlt commented May 8, 2024

davidos16 May 11, 2024

Choose a reason for hiding this comment

davidos16 commented May 11, 2024

jaredlt left a comment

Choose a reason for hiding this comment

jaredlt Jun 21, 2024

Choose a reason for hiding this comment

jaredlt Jun 21, 2024

Choose a reason for hiding this comment

jared-thoughtbot commented Sep 14, 2024

jared-thoughtbot commented Sep 18, 2024