Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chex to dependencies #151

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Add chex to dependencies #151

merged 1 commit into from
Jan 16, 2025

Conversation

jakevdp
Copy link
Collaborator

@jakevdp jakevdp commented Jan 15, 2025

Fixes #150

@jakevdp jakevdp self-assigned this Jan 15, 2025
@jakevdp jakevdp requested a review from skye January 15, 2025 00:15
@Tomas542
Copy link

Also kinda fixes #120

@jakevdp
Copy link
Collaborator Author

jakevdp commented Jan 15, 2025

Looking more closely, we may want to rethink this. chex currently depends on the dm-tree package which appears to be more-or-less unmaintained (no release since 2022: https://pypi.org/project/dm-tree/#history) and in particular is not installable on Python 3.13, which means chex is not compatible with Python 3.13.

I'd like some assurances that chex and its requirements will continue to be maintained before we make it an official part of the stack.

@jakevdp
Copy link
Collaborator Author

jakevdp commented Jan 15, 2025

The chex python 3.13 issue is addressed in google-deepmind/chex#378

@jakevdp
Copy link
Collaborator Author

jakevdp commented Jan 16, 2025

Given that the dependency issue is solved, and given that optax is unlikely to remove the chex requirement, I think it makes sense to add chex to the jax-ai-stack package. I'm going to merge this!

@jakevdp jakevdp merged commit 6e8aeaf into jax-ml:main Jan 16, 2025
16 checks passed
@jakevdp jakevdp deleted the chex branch January 16, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add chex
2 participants