Fixed the config setter.

jaxon-php · Jan 13, 2025 · 2e1e62e · 2e1e62e
1 parent eb4f8c0
commit 2e1e62e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 13 deletions.
diff --git a/src/Plugin/Manager/PackageManager.php b/src/Plugin/Manager/PackageManager.php
@@ -105,8 +105,9 @@ private function registerCallables(array $aOptions, string $sCallableType)
             {
                 // Register a function without options
                 $this->xPluginManager->registerCallable($sCallableType, $xValue);
+                continue;
             }
-            elseif(is_string($xKey) && (is_array($xValue) || is_string($xValue)))
+            if(is_string($xKey) && (is_array($xValue) || is_string($xValue)))
             {
                 // Register a function with options
                 $this->xPluginManager->registerCallable($sCallableType, $xKey, $xValue);

diff --git a/tests/TestMisc/ConfigTest.php b/tests/TestMisc/ConfigTest.php
@@ -102,18 +102,6 @@ public function testSimpleArrayValues()
         $this->assertEmpty(jaxon()->config()->getOptionNames('core.array'));
     }
 
-    /**
-     * @throws SetupException
-     */
-    public function testSetOptionsError()
-    {
-        // The key is missing
-        $this->assertFalse(jaxon()->config()->setOptions(['core' => []], 'core.missing'));
-        // The key is not an array
-        $this->assertFalse(jaxon()->config()->setOptions(['core' => ['string' => 'String']], 'core.string'));
-        $this->assertFalse(jaxon()->hasOption('core.string'));
-    }
-
     /**
      * @throws SetupException
      */