Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: @nutui/icons-react changed to @nutui/icons-react-taro #2651

Merged
merged 1 commit into from
Oct 21, 2024
Merged

fix: @nutui/icons-react changed to @nutui/icons-react-taro #2651

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/packages/calendar/demos/taro/demo1.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React, { useState } from 'react'
import { Cell, Calendar } from '@nutui/nutui-react-taro'
import { Star } from '@nutui/icons-react'
import { Star } from '@nutui/icons-react-taro'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

发现依赖配置问题。

package.json 中同时存在 @nutui/icons-react 和 @nutui/icons-react-taro 依赖，建议移除未使用的 @nutui/icons-react 以保持依赖一致性。

🔗 Analysis chain

导入路径更新正确。

导入语句的更改符合预期，将 Star 图标的来源从 @nutui/icons-react 更新为 @nutui/icons-react-taro。这与 PR 的目标一致。

运行以下脚本以验证项目中的一致性：

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# 描述：检查项目中是否还有其他使用 @nutui/icons-react 的地方

# 测试：搜索 @nutui/icons-react 的使用情况。预期：应该没有匹配项。
rg -i '@nutui/icons-react(?!-taro)' --type ts --type tsx

# 测试：检查 package.json 中的依赖。预期：应该使用 @nutui/icons-react-taro。
jq '.dependencies["@nutui/icons-react-taro"]' package.json
jq '.dependencies["@nutui/icons-react"]' package.json

Length of output: 442


const Demo1 = () => {
const d = new Date()
Expand Down
Loading