Border Router STUN Server Implementation #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcfrei
requested changes
Feb 20, 2025
marcfrei
reviewed
Feb 20, 2025
marcfrei
requested changes
Feb 24, 2025
There was a problem hiding this comment.
- Very nice that all customizations of the test topology are encapsulated in demo/stun/test.py now!
- Unfortuantely, there have been quite some changes in upstream scionproto. Could you please try and rebase this branch and also your other branch
upstream-masteron scionproto again?
marcfrei
requested changes
Feb 24, 2025
marcfrei
requested changes
Feb 24, 2025
| @@ -0,0 +1,129 @@ | |||
| #!/usr/bin/env python3 | |||
|
|
|||
| # Copyright 2024 ETH Zurich | |||
There was a problem hiding this comment.
It would be good to also have a README.md for this demo. Possibly with some ASCII art like, e.g., in demo/file_transfer/README.md.
tzaeschke
reviewed
Feb 24, 2025
demo/stun/test.py
Outdated
| file.write(filecontent) | ||
|
|
||
| def _run(self): | ||
| time.sleep(20) # wait for everything to start up |
There was a problem hiding this comment.
This seems a bit excessive...?
Have you tried that on CI?
There was a problem hiding this comment.
I reduced the waiting time to 10s now. This is also the waiting time in the DRKey Acceptance Test.
jdslab
force-pushed
the
upstream-master
branch
from
5121f6b to
abd39af
Compare
tzaeschke
reviewed
Feb 26, 2025
|
There's quite some activity on scionproto at the moment. Could you please rebase this branch on the most recent version again so that we can see the real diff again? |
added 17 commits
February 27, 2025 17:09
added 23 commits
February 27, 2025 17:09
…r on same port as SCION dataplane
- less overhead - less modification of STUN library - no disadvantages expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modification to border router dataplane to process STUN requests, as described in the design document and discussion.