Integrate text on APE 5 and departures from it #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffjennings
changed the title
mhvk
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
@jeffjennings - this looks all good to me! Though obviously the person really to ask is @eteq (Erik: this PR has changes following your larger comment about integration with APE 5).
|
Great, thanks Marten! (Exactly, I was just waiting to leave some inline replies to @eteq's comments in the main APE PR; I'll merge this and leave them now.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to comments raised in astropy#112, this PR adds text to place APE26 in the context of APE5 and explicitly note departures from the approach/implementation in APE5.