-
-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tvOS] Add pin prompt to sign-in screen #1383
Conversation
- Move UserProfileSettings to their own Coordinator - Make Views Modal to better reflect existing items - Fix CustomizeSettingsCoordinator (This is on me!) - Change PINs to use SecureField - Move all Settings View to use SplitFormWindowView to mirror existing Settings - Use user profile image for SplitFormWindowView Icon - Change Profile Security to use LearnMoreModal - Use suggestion from https://forums.developer.apple.com/forums/thread/739545 - Tag Alert > TextFields with TODO so we can check this on tvOS 18
I am so sorry, @chickdan! I didn't realize those would just direct commit I thought those would send you a PR to your local branch! You are totally welcome to revert those! Here is what I wanted to send as changes. I'm sure @LePips will have a much better insight but just from my prior tvOS PRs:
Sorry again for the commit over! Please let me know if you have any questions! |
@JPKribs no worries! I leave the "allow maintainers to make changes" box selected for this very reason 🙂 these new designs look SO MUCH better! These two PRs are my first foray into tvOS so I am still very much unfamiliar with design standards so this is very helpful, thank you! I'll look into the code changes and respond to the rest of your comments tonight after work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for implementing this @chickdan and thank you for the changes @JPKribs. tvOS "design" is still pretty dynamic as we figure out better UX interactions on the platform. For example, we may want to change the Save
button from the navigation bar into a button in the list, similar to Change User
.
Most of this is brought over from iOS with little changed. I removed
LocalAuthentication
since the framework does not support tvOS so the security options right now arenone
orpincode
.One oddity I noticed that seems specific to tvOS is that TextField with placeholder text will add an additional button to alerts that have the same text as the placeholder. Clicking the button opens the keyboard but it's a bit odd so I'm not sure if that is desired to be kept in there.
Example:
I also left in the password reset and reset settings buttons (but commented out) for later use if it's desired to include that functionality.
Set pin
set_pin.mp4
Attempt Login
pin_login.mov