Add local .git/config support

[0x2b3bfa0]

This pull request allows Dulwich to load local configuration from .git/config through StackedConfig.default() by inferring the configuration file path from either the GIT_DIR environment variable or the current directory. The added functions are simplified implemetations of the following Git functions:

• _parse_git_file ➔ read_gitfile_gently
• _is_git_directory ➔ is_git_directory
• _find_git_directory ➔ setup_git_directory_gently_1

I don't know if taking into account the current working directory is too unpredictable for non-porcelain code, though. Any feedback would be highly appreciated.

[jelmer]

Thanks for the pull request.

The three helper functions belong in dulwich.repo, since they're not config-specific. The functionality already exists today, so if you factor out into separate functions please update the existing code to use those functions as well.

Config.default_backends() intentionally doesn't use try to load the local repository configuration. See Repo.get_config_stack() for that.

[0x2b3bfa0]

🙏🏼 Thank you very much for your reply!

The three helper functions belong in dulwich.repo, since they're not config-specific. The functionality already exists today, so if you factor out into separate functions please update the existing code to use those functions as well.

I've noticed that read_gitfile already exists on dulwich/repo.py and both Repo.__init__ and Repo.discover already implement the proposed functionality. 🙈

Config.default_backends() intentionally doesn't use try to load the local repository configuration. See Repo.get_config_stack() for that.

As per #638 (comment), dulwich.porcelain.<command> should work like git <command> [...] including behaviour around os.getcwd 🤔 If Config.default_backends() is not intended to replicate the functionality of git-config as suggested in the code, where should this logic be implemented?

[jelmer]

On Sat, Jun 12, 2021 at 09:04:47AM -0700, Helio Machado wrote: > _`Config.default_backends()` intentionally doesn't use try to load the local repository configuration. See `Repo.get_config_stack()` for that._ As per #638 (comment), `dulwich.porcelain.<command>` should work like `git <command>` [...] including behaviour around `os.getcwd` 🤔 If `Config.default_backends()` is not intended to replicate the functionality of [`git-config`](https://git-scm.com/docs/git-config) as suggested in the code, where should this logic be implemented?

The intended code path for obtaining the config for a repository is Repo('.').get_config_stack().

…

-- Jelmer Vernooij ***@***.***> PGP Key: https://www.jelmer.uk/D729A457.asc

[0x2b3bfa0]

Understood! This pull request doesn't make any sense at all: Repo.discover().get_config_stack() does exactly the same thing I tried to do, and it would just be matter of connecting it to the porcelain functions that need it. 🤦🏼 Sorry for the noise.