Skip to content

Commit

Permalink
Use the correct separator character
Browse files Browse the repository at this point in the history
The AWS SDK expects to use pipe instead of comma
  • Loading branch information
BradyShober authored Jan 21, 2025
1 parent 4d5bbd1 commit cd107e0
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ protected ClientConfiguration createClientConfiguration() {
clientConfiguration.setProxyPassword(proxy.getPassword());
if (proxy.getNoProxyHost() != null) {
String[] noProxyParts = proxy.getNoProxyHost().split("[ \t\n,|]+");
clientConfiguration.setNonProxyHosts(Joiner.on(',').join(noProxyParts));
clientConfiguration.setNonProxyHosts(Joiner.on('|').join(noProxyParts));

Check warning on line 44 in src/main/java/com/cloudbees/jenkins/plugins/amazonecs/aws/BaseAWSService.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Not covered line

Line 44 is not covered by tests
}
}

Expand Down

0 comments on commit cd107e0

Please sign in to comment.