Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mask negative bits to prevent negative projectIds in BuildForm.java and ProjectForm.java #157

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

shlomomdahan
Copy link

IDs were sometimes being returned as negative ints which break pipeline functionality.

ref:

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@shlomomdahan shlomomdahan requested a review from a team as a code owner November 8, 2024 20:35
shlomomdahan added a commit to shlomomdahan/build-pipeline-plugin that referenced this pull request Nov 8, 2024
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@basil basil merged commit 7da034a into jenkinsci:master Nov 8, 2024
13 of 15 checks passed
@shlomomdahan shlomomdahan deleted the fix-negative-projectIds branch November 8, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants